Skip to content

Commit f574fe8

Browse files
MarcoFalkePastaPastaPasta
authored andcommitted
Merge bitcoin-core/gui#254: refactor: Drop redundant setEditTriggers(NoEditTriggers) calls
257f55c qt, refactor: Drop redundant setEditTriggers(NoEditTriggers) calls (Hennadii Stepanov) Pull request description: The models of the both views have no `Qt::ItemIsEditable` flag: https://github.com/bitcoin-core/gui/blob/3c87dbe95c925274f80234ad4a88beb5a05fdfff/src/qt/peertablemodel.cpp#L218-L224 https://github.com/bitcoin-core/gui/blob/3c87dbe95c925274f80234ad4a88beb5a05fdfff/src/qt/bantablemodel.cpp#L148-L154 ACKs for top commit: Talkless: utACK 257f55c, seems reasonable. jarolrod: ACK 257f55c, looks correct. Tree-SHA512: 4356e4d785055935fba452488a5d97ed95995def97b26ab18af43a545835f9e9d4c347e4cad7952aa725179cf6e775a2208c48730feebf40e3b1a7ba5f402af0
1 parent 803786c commit f574fe8

File tree

1 file changed

+0
-2
lines changed

1 file changed

+0
-2
lines changed

src/qt/rpcconsole.cpp

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -619,7 +619,6 @@ void RPCConsole::setClientModel(ClientModel *model)
619619
// set up peer table
620620
ui->peerWidget->setModel(model->getPeerTableModel());
621621
ui->peerWidget->verticalHeader()->hide();
622-
ui->peerWidget->setEditTriggers(QAbstractItemView::NoEditTriggers);
623622
ui->peerWidget->setSelectionBehavior(QAbstractItemView::SelectRows);
624623
ui->peerWidget->setSelectionMode(QAbstractItemView::ExtendedSelection);
625624
ui->peerWidget->setContextMenuPolicy(Qt::CustomContextMenu);
@@ -672,7 +671,6 @@ void RPCConsole::setClientModel(ClientModel *model)
672671
// set up ban table
673672
ui->banlistWidget->setModel(model->getBanTableModel());
674673
ui->banlistWidget->verticalHeader()->hide();
675-
ui->banlistWidget->setEditTriggers(QAbstractItemView::NoEditTriggers);
676674
ui->banlistWidget->setSelectionBehavior(QAbstractItemView::SelectRows);
677675
ui->banlistWidget->setSelectionMode(QAbstractItemView::SingleSelection);
678676
ui->banlistWidget->setContextMenuPolicy(Qt::CustomContextMenu);

0 commit comments

Comments
 (0)