Skip to content

Builder keys #964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 9, 2023
Merged

Builder keys #964

merged 5 commits into from
May 9, 2023

Conversation

pinheadmz
Copy link
Contributor

Closes #945
Closes #957 (included)
Closes #807 (included)
Closes #878

download + verify procedure tested on macOS and Linux. I will go through it again on Windows tonight and add one more commit for that.

@fanquake
Copy link
Member

fanquake commented May 9, 2023

## Check for broken Markdown reference-style links that are displayed in text unchanged, e.g. [broken][broken link]
! find _site/ -name '*.html' | xargs grep ']\[' | grep -v skip-test | grep .
## Ensure that no template strings leak through liquid rendering
! find _site/ -name '*.html' | xargs grep '\$(.*)'
_site/es/download/index.html:<p>Por ejemplo, dada la línea <a href="$(BUILDER_KEYS_TXT_URL)"><code> builder-keys/keys.txt</code></a> <code>$(EXAMPLE_BUILDERS_LINE)</code> podrías cargar esa clave usando este comando:</p>
_site/es/download/index.html:<p>Por ejemplo, dada la línea <a href="$(BUILDER_KEYS_TXT_URL)"><code> builder-keys/keys.txt</code></a> <code>$(EXAMPLE_BUILDERS_LINE)</code> podrías cargar esa clave usando este comando:</p>
_site/es/download/index.html:      <li><p>Sería recomendable que eligieras varias personas de esta lista que estimes confiables e importes sus claves según se indica arriba, o importes todas las claves según las instrucciones en el documento <a href="$(BUILDER_KEYS_URL)"><code>contrib/builder-key</code> README</a>. Después usarás sus claves para comprobar las firmas que atestiguan la validez de las checksums que usas para comprobar los programas binarios.
_site/es/download/index.html:<p>Por ejemplo, dada la línea <a href="$(BUILDER_KEYS_TXT_URL)"><code> builder-keys/keys.txt</code></a> <code>$(EXAMPLE_BUILDERS_LINE)</code> podrías cargar esa clave usando este comando:</p>
_site/es/download/index.html:      <li><p>Sería recomendable que eligieras varias personas de esta lista que estimes confiables e importes sus claves según se indica arriba, o importes todas las claves según las instrucciones en el documento <a href="$(BUILDER_KEYS_URL)"><code>contrib/builder-key</code> README</a>. Después usarás sus claves para comprobar las firmas que atestiguan la validez de las checksums que usas para comprobar los programas binarios.
make: *** [Makefile:23: test-fast] Error 1

@pinheadmz
Copy link
Contributor Author

Fixed build error by completing spanish translation (muchas gracias, @sr-gi !)

For quick review I built the download page (only) and hosted english and spanish:

https://thebitcoinblockclock.com/bitcoin/es-download

https://thebitcoinblockclock.com/bitcoin/en-download

pinheadmz and others added 4 commits May 9, 2023 15:06
checked with macOS Monterey (12.6.5) on M1 MacBook Air
checked with Ubuntu 22.04 (jammy) in a docker container
Change gitian -> guix
Co-authored-by: Sergi Delgado Segura <sergi.delgado.s@gmail.com>
@achow101
Copy link
Member

achow101 commented May 9, 2023

ACK bfbf19d

The rendered changes look correct and the links all work.

@achow101 achow101 merged commit 06202de into bitcoin-core:master May 9, 2023
@pinheadmz
Copy link
Contributor Author

I followed the steps successfully on my windows machine last night. A few weird things about it though I don't if its this way for a reason or not:

Ensure that the checksum produced by the command above matches one of
the checksums listed in the checksums file you downloaded earlier. We
recommend that you check every character of the two checksums to
ensure they match.

Manually verifying 64 characters? I'm no Windows expert but I think you can basically grep:

type SHA256SUMS | findstr 4cc2fe2e2f5e6068ecbf922564f2356a5388e4d00d8f852062f589b9577a21de

and the last one:

C:\Program Files (x86)\GnuPG\bin\gpg.exe

This wasn't my path for gpg and actually I found on my machine at least I could just execute the command gpg.exe without a path and it would work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Verification docs outdated
6 participants