Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply code review suggestions to seednode changes #6454

Merged
merged 7 commits into from
Dec 12, 2022
Merged

Apply code review suggestions to seednode changes #6454

merged 7 commits into from
Dec 12, 2022

Commits on Dec 11, 2022

  1. Make fields final. 

    Remove setter of key.

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
    @HenrikJannsen
    HenrikJannsen committed Dec 11, 2022
    Configuration menu
    Copy the full SHA
    21c6c52 View commit details
    Browse the repository at this point in the history

  2. Add params to newCachedThreadPool method. 

    Use executor at httpClient builder.
Use httpClient.sendAsync.
Add keep-alive header.
Add RejectedExecutionHandler.

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
    @HenrikJannsen
    HenrikJannsen committed Dec 11, 2022
    Configuration menu
    Copy the full SHA
    6addd27 View commit details
    Browse the repository at this point in the history

  3. Only log errors if shutdown is not in progress. 

    I want to avoid to risk changes with not calling error handlers/listeners in those cases
as not 100% sure if that could have unintended effects.

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
    @HenrikJannsen
    HenrikJannsen committed Dec 11, 2022
    Configuration menu
    Copy the full SHA
    1e32d86 View commit details
    Browse the repository at this point in the history

  4. Refactor: Move monitor package from core to seedNode and rename to re… 

    …porting

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
    @HenrikJannsen
    HenrikJannsen committed Dec 11, 2022
    Configuration menu
    Copy the full SHA
    1b10cc2 View commit details
    Browse the repository at this point in the history

  5. Refactor: Move SeedNodeReportingService to reporting package 

    Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
    @HenrikJannsen
    HenrikJannsen committed Dec 11, 2022
    Configuration menu
    Copy the full SHA
    53c031d View commit details
    Browse the repository at this point in the history

  6. Add proto to seed node 

    Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
    @HenrikJannsen
    HenrikJannsen committed Dec 11, 2022
    Configuration menu
    Copy the full SHA
    3ae52db View commit details
    Browse the repository at this point in the history

  7. Rename *ValueItem to *ValueReportingItem 

    Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
    @HenrikJannsen
    HenrikJannsen committed Dec 11, 2022
    Configuration menu
    Copy the full SHA
    f28e396 View commit details
    Browse the repository at this point in the history