-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply code review suggestions to seednode changes #6454
Apply code review suggestions to seednode changes #6454
Conversation
Remove setter of key. Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
Use executor at httpClient builder. Use httpClient.sendAsync. Add keep-alive header. Add RejectedExecutionHandler. Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
I want to avoid to risk changes with not calling error handlers/listeners in those cases as not 100% sure if that could have unintended effects. Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
…porting Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
@HenrikJannsen Should this be included in v1.9.7? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK
Hi @HenrikJannsen !
I looked over your changes and looks good to me. I saw you moved the ReportingItem
s to the seednode package. Good job!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK - based on #6454 (review)
Apply suggestions from #6432 (comment)