Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update site copy #389

Merged
merged 8 commits into from
Aug 27, 2020
Merged

Update site copy #389

merged 8 commits into from
Aug 27, 2020

Conversation

m52go
Copy link
Contributor

@m52go m52go commented Aug 12, 2020

This PR is a thorough revamp of the copy, primarily on the front page and FAQ page, but it includes other updates such as removing the 0.8.0 message for the notification apps on the download page.

Review Guidance

This looks like a big PR but it's largely English text updates, making this more of a a copyediting / proofreading exercise. You can disregard all the non-English .yml changes...those are mostly included in this PR for Transifex consistency and will be overwritten by Transifex soon anyway.

I recommend focusing on the changes in _data/en/yml. See how the changes come through on the staging website, mainly on the front page and FAQ page. Please pay special attention to dumb typos and broken links (I'm good at doing both).

@MwithM anything you would change on the proposed FAQ page? I switched the order of the first 2 questions, and removed the one about editing offers, as I believe you did on the wiki FAQ page, but I'm not sure if I missed other changes you made.

@Bayernatoor
Copy link
Member

82eae96 - Front page:

  • I may be off on this but we mention "Decentralized" pDecentralized: Trading takes place on a global P2P network of users running Bisq on their own machines. Perhaps "Distributed" is more appropriate for Bisq, it seems to fall in the "Distributed" network category - reference

394ba19 - FAQ (headers)

  • Perhaps change "doing" to "using".

    The Bisq DAO
    "Is Bisq doing a token because it needs money? What's the issuance schedule for the token?"

  • Upper case B in "Bitcoin" - all others are lowercase.

    Miscellaneous
    "What is a Bitcoin multisignature address?"


Everything else looks good to me - Proofread FAQs and Front Page, clear and concise, typo free and all the links work.

@m52go
Copy link
Contributor Author

m52go commented Aug 27, 2020

Perhaps "Distributed" is more appropriate for Bisq

I agree with you here in principle (especially since the copy references the trading network, which really is distributed) but I think it would be better to keep it as "decentralized" for now as more people are probably more familiar with it. Bitcoins seems to use "decentralized" more than distributed (source 1, source 2) too.

@m52go m52go merged commit 7e00fee into bisq-network:master Aug 27, 2020
@m52go m52go deleted the update-site-copy branch August 27, 2020 12:25
@Bayernatoor
Copy link
Member

Bah I missed your comment. I agree, less confusion!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants