-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Magpie integrate new feats #224
Conversation
E2E Test ResultsDACCS-iac Pipeline ResultsBuild URL : http://daccs-jenkins.crim.ca:80/job/DACCS-iac-birdhouse/777/Result : failure BIRDHOUSE_DEPLOY_BRANCH : magpie-integrate-new-feats DACCS_CONFIGS_BRANCH : master PAVICS_E2E_WORKFLOW_TESTS_BRANCH : master PAVICS_SDI_BRANCH : master DESTROY_INFRA_ON_EXIT : true PAVICS_HOST : https://host-140-46.rdext.crim.ca PAVICS-e2e-workflow-tests Pipeline ResultsTests URL : http://daccs-jenkins.crim.ca:80/job/PAVICS-e2e-workflow-tests/job/master/662/NOTEBOOK TEST RESULTS |
@ChaamC can you port the switch to gunicorn from #197 here and then dump that PR. The DEBUG logging, we do not want to keep it in prod, see comment #197 (comment) |
E2E Test ResultsDACCS-iac Pipeline ResultsBuild URL : http://daccs-jenkins.crim.ca:80/job/DACCS-iac-birdhouse/778/Result : failure BIRDHOUSE_DEPLOY_BRANCH : magpie-integrate-new-feats DACCS_CONFIGS_BRANCH : master PAVICS_E2E_WORKFLOW_TESTS_BRANCH : master PAVICS_SDI_BRANCH : master DESTROY_INFRA_ON_EXIT : true PAVICS_HOST : https:// PAVICS-e2e-workflow-tests Pipeline ResultsTests URL :NOTEBOOK TEST RESULTS
|
PR updated with latest feedback and with the switch to gunicorn from #197 (as requested by comment.) PR #197 will be dumped after this PR is merged, if it works for you. @tlvu @fmigneault |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, minor change requested, then good to merge.
Remember:
- to merge with latest if applicable so you bump to the good version
- to perform the bump2version stuff before merging
- to copy/paste the content of the PR description (and update the description if needed) into the merge commit so it shows up nicely in https://github.com/bird-house/birdhouse-deploy/tags
- to push the matching tag after you merge
If this new Magpie is 100% backward-compat, then bump2version patch
, else bump2version minor
.
Thanks.
Sorry, just a note that to check whether this PR is 100% backward-compat, check the diff versus the previous Magpie in this repo, meaning an upgrade from 3.14.0 to 3.18.0 to avoid the previous oopsies here #182 (comment). Edit:
|
…_port and smtp_ssl
The Magpie update should be backward compatible, since it includes optional features. Some column was added to the db, but the modifications shouldn't create any conflicts. PR was updated with latest feedback. Also, Magpie 3.18.1 will be included in this PR soon (instead of 3.18.0), waiting for a go from @fmigneault to continue. |
E2E Test ResultsDACCS-iac Pipeline ResultsBuild URL : http://daccs-jenkins.crim.ca:80/job/DACCS-iac-birdhouse/782/Result : failure BIRDHOUSE_DEPLOY_BRANCH : magpie-integrate-new-feats DACCS_CONFIGS_BRANCH : master PAVICS_E2E_WORKFLOW_TESTS_BRANCH : master PAVICS_SDI_BRANCH : master DESTROY_INFRA_ON_EXIT : true PAVICS_HOST : https://host-140-91.rdext.crim.ca PAVICS-e2e-workflow-tests Pipeline ResultsTests URL : http://daccs-jenkins.crim.ca:80/job/PAVICS-e2e-workflow-tests/job/master/666/NOTEBOOK TEST RESULTS |
E2E Test ResultsDACCS-iac Pipeline ResultsBuild URL : http://daccs-jenkins.crim.ca:80/job/DACCS-iac-birdhouse/792/Result : failure BIRDHOUSE_DEPLOY_BRANCH : magpie-integrate-new-feats DACCS_CONFIGS_BRANCH : master PAVICS_E2E_WORKFLOW_TESTS_BRANCH : master PAVICS_SDI_BRANCH : master DESTROY_INFRA_ON_EXIT : true PAVICS_HOST : https://host-140-88.rdext.crim.ca PAVICS-e2e-workflow-tests Pipeline ResultsTests URL : http://daccs-jenkins.crim.ca:80/job/PAVICS-e2e-workflow-tests/job/master/675/NOTEBOOK TEST RESULTS |
closes #197 |
run tests |
E2E Test ResultsDACCS-iac Pipeline ResultsBuild URL : http://daccs-jenkins.crim.ca:80/job/DACCS-iac-birdhouse/793/Result : failure BIRDHOUSE_DEPLOY_BRANCH : magpie-integrate-new-feats DACCS_CONFIGS_BRANCH : master PAVICS_E2E_WORKFLOW_TESTS_BRANCH : master PAVICS_SDI_BRANCH : master DESTROY_INFRA_ON_EXIT : true PAVICS_HOST : https://host-140-88.rdext.crim.ca PAVICS-e2e-workflow-tests Pipeline ResultsTests URL : http://daccs-jenkins.crim.ca:80/job/PAVICS-e2e-workflow-tests/job/master/676/NOTEBOOK TEST RESULTS |
run tests |
E2E Test ResultsDACCS-iac Pipeline ResultsBuild URL : http://daccs-jenkins.crim.ca:80/job/DACCS-iac-birdhouse/794/Result : failure BIRDHOUSE_DEPLOY_BRANCH : magpie-integrate-new-feats DACCS_CONFIGS_BRANCH : master PAVICS_E2E_WORKFLOW_TESTS_BRANCH : master PAVICS_SDI_BRANCH : master DESTROY_INFRA_ON_EXIT : true PAVICS_HOST : https://host-140-88.rdext.crim.ca PAVICS-e2e-workflow-tests Pipeline ResultsTests URL : http://daccs-jenkins.crim.ca:80/job/PAVICS-e2e-workflow-tests/job/master/677/NOTEBOOK TEST RESULTS |
@ChaamC For later reference, this was the error:
Error raised when calling: service_factory(service, self._cached_request)
# ...
SERVICE_TYPE_DICT[service_type](service, request) Service object creation fails for some obscure reason. |
E2E Test ResultsDACCS-iac Pipeline ResultsBuild URL : http://daccs-jenkins.crim.ca:80/job/DACCS-iac-birdhouse/795/Result : success BIRDHOUSE_DEPLOY_BRANCH : magpie-integrate-new-feats DACCS_CONFIGS_BRANCH : master PAVICS_E2E_WORKFLOW_TESTS_BRANCH : master PAVICS_SDI_BRANCH : master DESTROY_INFRA_ON_EXIT : true PAVICS_HOST : https://host-140-88.rdext.crim.ca PAVICS-e2e-workflow-tests Pipeline ResultsTests URL : http://daccs-jenkins.crim.ca:80/job/PAVICS-e2e-workflow-tests/job/master/678/NOTEBOOK TEST RESULTS |
@fmigneault @ChaamC FYI Ouranos will deploy this new version of Magpie but without activating the cache feature because with the cache enabled on our staging,
Edit:
|
I believe that what you are seeing might be real client timeout, completely unrelated to caching.
I'm just throwing a wild guess here, but it could be possible that because of caching, requests/sec become much higher since each one takes less time to complete, and the server sometimes might not be able to take this heavier load. This could be a cause of sporadic timeout. The fact that you cannot find logs in twitcher also works with this hypothesis. That means the request never reaches twitcher/magpie caching and the problem is at the proxy/nginx level. |
Houston, we have a bigger problem here.
|
Please advice rollback procedure or if hotfix is possible. It's intermittent again, Happens on my 3rd Jenkins run only. |
I got many of those, no other stack-trace:
|
…vice completely finishes computing the object (relates to #490 and bird-house/birdhouse-deploy#224 (comment))
@tlvu Note that unless you enable debug logs on some instance, most of the time this stack-trace means nothing because it is a catch-all for any exception (including valid unauthorized/forbidden access). |
Do you suggest waiting for that fix or rollback now? What would be the rollback procedure?
It's our prod instance, I'd rather not enable the verbose debug logging. |
I think I'll move all the findings to a new Magpie issue. Commenting on a closed PR do not have much visibility. |
## Overview Pin new `magpie==3.19.1` image to fix #224 (comment). ## Related Issue / Discussion - Relates to #224 - Relates to Ouranosinc/Magpie#491 - Relates to Ouranosinc/Magpie#492
Overview
Update to latest Magpie version 3.19.0
Tested on a local birdhouse setup.
Changes
Non-breaking changes
Breaking changes
Following PR will have to be merged prior to merging this current PR : pavics-e2e #90
Also, PR birdhouse #197's content has been transfered to this PR.