Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix failing cached service creation #491

Merged
merged 3 commits into from
Dec 8, 2021
Merged

fix failing cached service creation #491

merged 3 commits into from
Dec 8, 2021

Conversation

fmigneault
Copy link
Collaborator

@fmigneault fmigneault commented Dec 7, 2021 •
edited
Loading

Changes

  • use uuid/request mapping to persist distinct handles until cached service completely finishes computing the object

References

@fmigneault fmigneault self-assigned this Dec 7, 2021
@github-actions github-actions bot added doc Documentation improvements or building problem plugin Service plugin labels Dec 7, 2021
@fmigneault fmigneault added the cache Features or issues related to caching. label Dec 7, 2021
fmigneault added a commit to bird-house/birdhouse-deploy that referenced this pull request Dec 7, 2021
@fmigneault
validate fix Ouranosinc/Magpie#491
ccab93f
This was referenced Dec 7, 2021
Merged
Merged
@fmigneault
Copy link
Collaborator Author

Docker images pavics/magpie:3.19.1-rc and pavics/twitcher:magpie-3.19.1-rc pushed manually since DockerHub is having difficulties with auto-builds at the moment.

dbyrns
dbyrns approved these changes Dec 8, 2021
View reviewed changes
Copy link
Contributor

@dbyrns dbyrns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fmigneault fmigneault merged commit 13b7b8e into master Dec 8, 2021
@fmigneault fmigneault deleted the cached-request-service-map branch December 8, 2021 23:21
@fmigneault fmigneault mentioned this pull request Dec 8, 2021
Closed
@fmigneault
Copy link
Collaborator Author

Images manually pushed.
Seem to still be having issues in automated builds.
Same error as described here:
https://forums.docker.com/t/failed-to-authorize-rpc-error-code-unknown-desc-failed-to-fetch-oauth-token-unexpected-status-401-unauthorized/118562/2

fmigneault added a commit to bird-house/birdhouse-deploy that referenced this pull request Dec 9, 2021
@fmigneault
Merge pull request #226 from bird-house/magpie-3.19.1
f2dcec3 
## Overview

Pin new `magpie==3.19.1` image to fix #224 (comment).

## Related Issue / Discussion

- Relates to #224
- Relates to Ouranosinc/Magpie#491
- Relates to Ouranosinc/Magpie#492
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbyrns dbyrns dbyrns approved these changes

Assignees

@fmigneault fmigneault

Labels
cache Features or issues related to caching. doc Documentation improvements or building problem plugin Service plugin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fmigneault @dbyrns