Added support for extra platforms. #51505
Conversation
📝 WalkthroughWalkthroughThe changes in this pull request primarily involve modifications to the Possibly related PRs
Suggested labels
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
recipes/diamond/meta.yaml (1)
Line range hint
22-22: Fix indentation for 'make' in build requirements.The 'make' dependency is incorrectly indented. It should be at the same level as other build requirements.
Please apply the following change:
build: - {{ compiler('c') }} - {{ compiler('cxx') }} - cmake - - make + - make
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
- recipes/diamond/meta.yaml (2 hunks)
🧰 Additional context used
🔇 Additional comments (4)
recipes/diamond/meta.yaml (4)
13-13: LGTM: Build number increment is appropriate.The build number has been correctly incremented from 0 to 1. This is the right approach when making changes to the package configuration without updating the upstream version.
Line range hint
18-31: LGTM: Removal of 'blast' dependency.The 'blast' dependency has been removed from both 'build' and 'run' requirements as intended. This aligns with the PR objective of addressing the dependency issue mentioned in the PR summary.
45-47: LGTM: Addition of new platforms.The addition of 'osx-arm64' and 'linux-aarch64' to the 'additional-platforms' section is correct and aligns with the PR objective of enhancing support for extra platforms.
Line range hint
1-47: Overall assessment: Changes look good with one minor fix needed.The changes in this PR successfully achieve the following objectives:
- Update the package version to 2.1.10
- Remove the problematic 'blast' dependency
- Add support for additional platforms (osx-arm64 and linux-aarch64)
These modifications align well with the PR objectives and improve the package's functionality and compatibility. The build number has been correctly incremented to reflect these changes.
There's only one minor issue to address:
- Fix the indentation of 'make' in the build requirements section.
Once this small correction is made, the PR should be ready for merging.
Added support for extra platforms. Removed blast depedency as compilation with blast support was not working anyway.
Please read the guidelines for Bioconda recipes before opening a pull request (PR).
General instructions
@BiocondaBot please add labelcommand.@bioconda/corein a comment.Instructions for avoiding API, ABI, and CLI breakage issues
Conda is able to record and lock (a.k.a. pin) dependency versions used at build time of other recipes.
This way, one can avoid that expectations of a downstream recipe with regards to API, ABI, or CLI are violated by later changes in the recipe.
If not already present in the meta.yaml, make sure to specify
run_exports(see here for the rationale and comprehensive explanation).Add a
run_exportssection like this:with
...being one of:{{ pin_subpackage("myrecipe", max_pin="x") }}{{ pin_subpackage("myrecipe", max_pin="x.x") }}{{ pin_subpackage("myrecipe", max_pin="x.x") }}(in such a case, please add a note that shortly mentions your evidence for that){{ pin_subpackage("myrecipe", max_pin="x.x.x") }}(in such a case, please add a note that shortly mentions your evidence for that){{ pin_subpackage("myrecipe", max_pin=None) }}while replacing
"myrecipe"with eithernameif aname|lowervariable is defined in your recipe or with the lowercase name of the package in quotes.Bot commands for PR management
Please use the following BiocondaBot commands:
Everyone has access to the following BiocondaBot commands, which can be given in a comment:
@BiocondaBot please update@BiocondaBot please add labelplease review & mergelabel.@BiocondaBot please fetch artifactsYou can use this to test packages locally.
Note that the
@BiocondaBot please mergecommand is now depreciated. Please just squash and merge instead.Also, the bot watches for comments from non-members that include
@bioconda/<team>and will automatically re-post them to notify the addressed<team>.