Add package doubletdetection #51786
Add package doubletdetection #51786
Conversation
📝 Walkthrough📝 WalkthroughWalkthroughThe pull request introduces an updated Possibly related PRs
Suggested labels
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Outside diff range and nitpick comments (1)
recipes/doubletdetection/meta.yaml (1)
49-56: Enhance test coverage.
The current tests only verify import and dependencies. Consider adding functional tests to verify key package capabilities.
Add basic functionality tests, for example:
test:
imports:
- doubletdetection
commands:
- pip check
+ - python -c "import doubletdetection; assert hasattr(doubletdetection, 'BoostClassifier')"
requires:
- pip📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
- recipes/doubletdetection/meta.yaml (1 hunks)
🧰 Additional context used
🪛 yamllint
recipes/doubletdetection/meta.yaml
[error] 1-1: syntax error: found character '%' that cannot start any token
(syntax)
🔇 Additional comments (2)
recipes/doubletdetection/meta.yaml (2)
57-61: Verify license file and repository URL.
Please ensure:
- The LICENSE.txt file exists in the source distribution
- The GitHub repository URL is correct and accessible
✅ Verification successful
Repository URL and license file verified successfully
Both checks passed:
- GitHub repository is accessible (HTTP 200)
- LICENSE.txt file exists in the source distribution
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Verify license file and repository
# Expected: License file exists and repository is accessible
# Check if repository exists and is accessible
curl -s -o /dev/null -w "%{http_code}" "https://github.com/JonathanShor/DoubletDetection"
# Download source and check for license file
curl -sL "https://pypi.org/packages/source/d/doubletdetection/doubletdetection-4.2.tar.gz" | tar tz | grep -i "license"
Length of output: 243
8-10: Verify package availability and checksum.
The source URL follows PyPI conventions, but let's verify its existence and integrity.
| host: | ||
| - python >=3.6,<4.0 | ||
| - poetry >=1.0 | ||
| - setuptools | ||
| - poetry-core | ||
| - pip | ||
| run: |
There was a problem hiding this comment.
Align Python version constraints between host and run sections.
The Python version requirements are inconsistent:
- host:
python >=3.6,<4.0 - run:
python >=3.6.1,<4.0
This could potentially cause build issues.
host:
- - python >=3.6,<4.0
+ - python >=3.6.1,<4.0
- poetry >=1.0Also applies to: 25-36
| run_constrained: | ||
| - black >=20.8b1 | ||
| - flake8 >=3.7.7 | ||
| - furo * | ||
| - myst-parser * | ||
| - nbsphinx * | ||
| - nbsphinx-link * | ||
| - pre-commit >=2.7.1 | ||
| - pytest >=4.4 | ||
| - sphinx >=4.1,<4.4 | ||
| - sphinx-autodoc-typehints * |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Consider moving development dependencies to optional features.
The run_constrained section includes development tools that aren't required for normal package operation. Consider making these optional to reduce the dependency footprint.
You could move these to optional features using outputs section or create a separate -dev package. Would you like me to provide an example implementation?
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
recipes/doubletdetection/meta.yaml (1)
51-53: Consider enhancing test coverage.
The current test only verifies that the package can be imported. Consider adding:
- Command line interface tests if applicable
- Basic functionality tests to ensure core features work
Example enhancement:
test:
imports:
- doubletdetection
+ commands:
+ - python -c "import doubletdetection; assert doubletdetection.__version__ == '4.2'"📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
- recipes/doubletdetection/meta.yaml (1 hunks)
🧰 Additional context used
🪛 yamllint
recipes/doubletdetection/meta.yaml
[error] 1-1: syntax error: found character '%' that cannot start any token
(syntax)
🔇 Additional comments (5)
recipes/doubletdetection/meta.yaml (5)
1-6: LGTM! Package metadata is well-defined.
The package name and version are correctly templated using Jinja2 syntax.
🧰 Tools
🪛 yamllint
[error] 1-1: syntax error: found character '%' that cannot start any token
(syntax)
12-18: LGTM! Build configuration follows best practices.
noarch: pythonis appropriate for this pure Python package- pip install flags prevent dependency conflicts
run_exportscorrectly pins the package version
55-66: LGTM! Package metadata is complete.
All required metadata fields are present and properly filled:
- Project links (home, dev_url, doc_url)
- License information
- Maintainer information
8-10: Verify source package availability and integrity.
The source URL follows PyPI's standard format, and a SHA256 checksum is provided.
✅ Verification successful
Source package URL and checksum verified successfully
The package is available on PyPI and the SHA256 checksum in the recipe (77273d543a7c9b4f4e795b7b664c28bce0613b3a3a7c7f5137974012400a0a6c) matches exactly with the official checksum from PyPI. The source configuration is correct and secure.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Verify package availability and checksum on PyPI
# Expected: URL should be accessible and checksum should match
# Test: Check if the package exists on PyPI
curl -s -o /dev/null -w "%{http_code}" "https://pypi.org/packages/source/d/doubletdetection/doubletdetection-4.2.tar.gz"
# Test: Download and verify checksum
curl -sL "https://pypi.org/packages/source/d/doubletdetection/doubletdetection-4.2.tar.gz" | sha256sum
Length of output: 303
Script:
#!/bin/bash
# Let's try a different approach using wget to download and verify
# First, check if the package exists on PyPI API
curl -s "https://pypi.org/pypi/doubletdetection/json" | jq -r '.urls[] | select(.filename == "doubletdetection-4.2.tar.gz") | .url'
# Get the package information from PyPI
curl -s "https://pypi.org/pypi/doubletdetection/json" | jq -r '.urls[] | select(.filename == "doubletdetection-4.2.tar.gz") | {url, digests}'
Length of output: 793
26-38: Consider adding upper bounds to dependencies.
Several runtime dependencies lack upper version bounds, which could lead to compatibility issues in the future. Consider adding upper bounds to critical dependencies:
Suggested bounds based on current stable versions:
- anndata >=0.6
+ - anndata >=0.6,<0.10.0
- ipywidgets
+ - ipywidgets <9.0.0
- leidenalg
+ - leidenalg <0.10.0
- louvain
+ - louvain <0.8.0
- phenograph
+ - phenograph <1.6.0
- scanpy >1.4.4
+ - scanpy >1.4.4,<1.10.0
Describe your pull request here
Please read the guidelines for Bioconda recipes before opening a pull request (PR).
General instructions
@BiocondaBot please add labelcommand.@bioconda/corein a comment.Instructions for avoiding API, ABI, and CLI breakage issues
Conda is able to record and lock (a.k.a. pin) dependency versions used at build time of other recipes.
This way, one can avoid that expectations of a downstream recipe with regards to API, ABI, or CLI are violated by later changes in the recipe.
If not already present in the meta.yaml, make sure to specify
run_exports(see here for the rationale and comprehensive explanation).Add a
run_exportssection like this:with
...being one of:{{ pin_subpackage("myrecipe", max_pin="x") }}{{ pin_subpackage("myrecipe", max_pin="x.x") }}{{ pin_subpackage("myrecipe", max_pin="x.x") }}(in such a case, please add a note that shortly mentions your evidence for that){{ pin_subpackage("myrecipe", max_pin="x.x.x") }}(in such a case, please add a note that shortly mentions your evidence for that){{ pin_subpackage("myrecipe", max_pin=None) }}while replacing
"myrecipe"with eithernameif aname|lowervariable is defined in your recipe or with the lowercase name of the package in quotes.Bot commands for PR management
Please use the following BiocondaBot commands:
Everyone has access to the following BiocondaBot commands, which can be given in a comment:
@BiocondaBot please update@BiocondaBot please add labelplease review & mergelabel.@BiocondaBot please fetch artifactsYou can use this to test packages locally.
Note that the
@BiocondaBot please mergecommand is now depreciated. Please just squash and merge instead.Also, the bot watches for comments from non-members that include
@bioconda/<team>and will automatically re-post them to notify the addressed<team>.