Xiangyang1984 patch 11 #51393
Xiangyang1984 patch 11 #51393
Conversation
Update meta.yaml
Update build.sh
Update meta.yaml
Update meta.yaml
Update the lastest meta.yaml
Update meta.yaml
📝 Walkthrough📝 WalkthroughWalkthroughThe pull request introduces modifications to the Possibly related PRs
Suggested labels
Suggested reviewers
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Outside diff range and nitpick comments (2)
recipes/pneumo-typer/build.sh (1)
7-7: Consider usingls -aonly in debug mode.The addition of
ls -ais helpful for debugging, but it may not be necessary for every build. Consider wrapping this command in a conditional statement that checks for a debug flag or environment variable.Example implementation:
if [ "${DEBUG:-false}" = "true" ]; then ls -a firecipes/pneumo-typer/meta.yaml (1)
12-12: Minor: Remove trailing spaces.There are trailing spaces on this line. While they don't affect functionality, it's good practice to remove them for consistency and to avoid potential issues in some systems.
You can remove the trailing spaces as follows:
- sha256: {{ sha256 }} + sha256: {{ sha256 }}🧰 Tools
🪛 yamllint
[error] 12-12: trailing spaces
(trailing-spaces)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (2)
- recipes/pneumo-typer/build.sh (2 hunks)
- recipes/pneumo-typer/meta.yaml (3 hunks)
🧰 Additional context used
🪛 yamllint
recipes/pneumo-typer/meta.yaml
[error] 12-12: trailing spaces
(trailing-spaces)
🔇 Additional comments (9)
recipes/pneumo-typer/build.sh (3)
8-8: Excellent use of$SRC_DIRvariable.The modification to use
$SRC_DIRinstead of a hardcoded directory is a significant improvement. This change makes the script more robust and portable, ensuring it works correctly regardless of the build environment.
24-24: Correct permission set for new executable.The addition of the chmod command for update_mlstdb_cgmlstdb is correct and necessary. It ensures that the new script has the proper executable permissions, consistent with the pneumo-typer script.
17-21: New executable added for update_mlstdb_cgmlstdb.pl.The addition of a new executable for update_mlstdb_cgmlstdb.pl is consistent with the existing structure. This is a good practice for maintaining uniformity in the package.
To ensure the new script exists, please run the following verification:
recipes/pneumo-typer/meta.yaml (6)
2-3: LGTM: Version and checksum update.The version bump to 1.0.2 and the corresponding SHA256 checksum update are consistent with the package update.
24-26: LGTM: Dependency version specifications added.Adding minimum version requirements for perl-gd (>=2.74) and perl-svg (>=2.87) is a good practice. It helps ensure compatibility and reproducibility of the build environment.
39-39: LGTM: New test command added.The addition of the test command
update_mlstdb_cgmlstdb -his a good practice. It helps ensure that the new executable is properly installed and accessible.
44-45: LGTM: Improved package description.The updated summary and new description provide more detailed information about Pneumo-Typer's capabilities and requirements. This improvement in documentation is beneficial for users.
46-46: LGTM: Documentation URL added.The addition of the documentation URL pointing to the GitHub repository is helpful. It provides users with a reliable source for more detailed information about the tool.
10-11: Verify the updated source URL.The source URL has been updated to use the 'gz' directory instead of 'temp_dir'. This change might indicate a more permanent location for the package.
Please run the following script to verify the accessibility and correctness of the new URL:
| @@ -12,7 +11,7 @@ source: | |||
| sha256: {{ sha256 }} | |||
|
|
|||
| build: | |||
| number: 1 | |||
| number: 2 | |||
There was a problem hiding this comment.
Query: Build number decrease.
The build number has been decreased from 3 to 2. Typically, the build number should be reset to 0 when the version is bumped, or incremented if there are changes without a version bump.
Could you please clarify the reason for decreasing the build number? If this was unintentional, consider updating it to:
number: 0
Xiangyang1984
requested review from
cumbof,
AstrobioMike,
suwangbio,
blinard-BIOINFO,
bioconda-bot,
BiocondaBot,
biocondabot2020 and
a team
mencian
removed request for
a team,
cumbof,
AstrobioMike,
suwangbio,
blinard-BIOINFO,
bioconda-bot,
BiocondaBot and
biocondabot2020
|
Can someone please block this user from submitting PRs until they provide a written response to the feedback and respect the written guidelines. Related #51364 (comment) |
|
Stop spamming bioconda/all! |
Xiangyang1984
requested review from
blinard-BIOINFO,
bioconda-bot,
BiocondaBot,
biocondabot2020 and
a team
wdecoster
removed request for
bioconda-bot,
BiocondaBot,
biocondabot2020 and
a team
|
@Xiangyang1984 Stop doing this. You are annoying all of us. |
Describe your pull request here
Please read the guidelines for Bioconda recipes before opening a pull request (PR).
General instructions
@BiocondaBot please add labelcommand.@bioconda/corein a comment.Instructions for avoiding API, ABI, and CLI breakage issues
Conda is able to record and lock (a.k.a. pin) dependency versions used at build time of other recipes.
This way, one can avoid that expectations of a downstream recipe with regards to API, ABI, or CLI are violated by later changes in the recipe.
If not already present in the meta.yaml, make sure to specify
run_exports(see here for the rationale and comprehensive explanation).Add a
run_exportssection like this:with
...being one of:{{ pin_subpackage("myrecipe", max_pin="x") }}{{ pin_subpackage("myrecipe", max_pin="x.x") }}{{ pin_subpackage("myrecipe", max_pin="x.x") }}(in such a case, please add a note that shortly mentions your evidence for that){{ pin_subpackage("myrecipe", max_pin="x.x.x") }}(in such a case, please add a note that shortly mentions your evidence for that){{ pin_subpackage("myrecipe", max_pin=None) }}while replacing
"myrecipe"with eithernameif aname|lowervariable is defined in your recipe or with the lowercase name of the package in quotes.Bot commands for PR management
Please use the following BiocondaBot commands:
Everyone has access to the following BiocondaBot commands, which can be given in a comment:
@BiocondaBot please update@BiocondaBot please add labelplease review & mergelabel.@BiocondaBot please fetch artifactsYou can use this to test packages locally.
Note that the
@BiocondaBot please mergecommand is now depreciated. Please just squash and merge instead.Also, the bot watches for comments from non-members that include
@bioconda/<team>and will automatically re-post them to notify the addressed<team>.