pepnovo: add aarch64/arm64 build #51206
Conversation
martin-g
added
aarch64
|
Warning Rate limit exceeded@BiocondaBot has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 15 minutes and 17 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📝 Walkthrough📝 Walkthrough📝 Walkthrough📝 Walkthrough📝 WalkthroughWalkthroughThis pull request introduces significant updates to the Possibly related PRs
Suggested labels
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
martin-g
force-pushed
the
aarch64-pepnovo
branch
from
69074ec
to
608e2dc
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Outside diff range and nitpick comments (2)
recipes/pepnovo/build.sh (1)
9-9: Great optimization for parallel compilation!The addition of
-j ${CPU_COUNT}to themakecommand enables parallel compilation, which can significantly speed up the build process on multi-core systems. This is an excellent optimization.Consider adding a fallback value for
CPU_COUNTin case it's not set:-make -j ${CPU_COUNT} CC="${CXX}" CFLAGS="${CXXFLAGS} -Wno-narrowing " LDFLAGS="${LDFLAGS}" +make -j ${CPU_COUNT:-1} CC="${CXX}" CFLAGS="${CXXFLAGS} -Wno-narrowing " LDFLAGS="${LDFLAGS}"This ensures that if
CPU_COUNTis not set, the build will still proceed with a single job.recipes/pepnovo/meta.yaml (1)
13-14: Consider a more conservative pinning strategy.The addition of
run_exportsis a good practice for managing dependencies. However, the current configuration (max_pin=None) allows any future version of pepnovo to satisfy the dependency requirement. This might be too permissive.Consider using a more conservative pinning strategy, such as
max_pin='x.x'ormax_pin='x', depending on your versioning scheme and how often you expect to make breaking changes. For example:run_exports: - {{ pin_subpackage('pepnovo', max_pin='x.x') }}This would ensure that only minor version updates are automatically accepted, reducing the risk of unexpected breaking changes.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (3)
- build-fail-blacklist (0 hunks)
- recipes/pepnovo/build.sh (1 hunks)
- recipes/pepnovo/meta.yaml (2 hunks)
💤 Files with no reviewable changes (1)
- build-fail-blacklist
🧰 Additional context used
🔇 Additional comments (3)
recipes/pepnovo/build.sh (1)
3-3: Excellent addition for improved error handling and debugging!The
set -xecommand is a great addition to the build script. It enables immediate exit on any command failure (-e) and prints each command before execution (-x). This will make debugging easier and ensure that the build process stops if any step fails.recipes/pepnovo/meta.yaml (2)
12-12: LGTM: Build number increment is appropriate.The build number has been correctly incremented from 3 to 4. This is in line with best practices for package management, especially when making changes that don't affect the package version itself.
33-35: LGTM: New platform support added as intended.The addition of 'linux-aarch64' and 'osx-arm64' to the 'additional-platforms' list is in line with the PR's main objective of adding aarch64/arm64 build support. This change will enable the package to be built and used on ARM-based systems, increasing its compatibility and reach.
To ensure full compatibility, please run the following script to check for any architecture-specific code or dependencies that might need adjustment:
Please review the output of this script to ensure that there are no unexpected architecture-specific elements that might cause issues on the new platforms.
Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
martin-g
force-pushed
the
aarch64-pepnovo
branch
from
2d8da7e
to
4b02765
Compare
Trying to fix: ``` base64.cpp:124:11: error: ISO C++17 does not allow 'register' storage class specifier [-Wregister]�[0m 2024-10-08T08:41:28.5270550Z 08:41:27 �[32mBIOCONDA INFO�[0m (ERR) int register a;�[0m ```
|
@BiocondaBot please fetch artifacts |
|
Package(s) built are ready for inspection:
Docker image(s) built:
|
LGTM! |
|
@BiocondaBot please add label |
Describe your pull request here
Please read the guidelines for Bioconda recipes before opening a pull request (PR).
General instructions
@BiocondaBot please add labelcommand.@bioconda/corein a comment.Instructions for avoiding API, ABI, and CLI breakage issues
Conda is able to record and lock (a.k.a. pin) dependency versions used at build time of other recipes.
This way, one can avoid that expectations of a downstream recipe with regards to API, ABI, or CLI are violated by later changes in the recipe.
If not already present in the meta.yaml, make sure to specify
run_exports(see here for the rationale and comprehensive explanation).Add a
run_exportssection like this:with
...being one of:{{ pin_subpackage("myrecipe", max_pin="x") }}{{ pin_subpackage("myrecipe", max_pin="x.x") }}{{ pin_subpackage("myrecipe", max_pin="x.x") }}(in such a case, please add a note that shortly mentions your evidence for that){{ pin_subpackage("myrecipe", max_pin="x.x.x") }}(in such a case, please add a note that shortly mentions your evidence for that){{ pin_subpackage("myrecipe", max_pin=None) }}while replacing
"myrecipe"with eithernameif aname|lowervariable is defined in your recipe or with the lowercase name of the package in quotes.Bot commands for PR management
Please use the following BiocondaBot commands:
Everyone has access to the following BiocondaBot commands, which can be given in a comment:
@BiocondaBot please update@BiocondaBot please add labelplease review & mergelabel.@BiocondaBot please fetch artifactsYou can use this to test packages locally.
Note that the
@BiocondaBot please mergecommand is now depreciated. Please just squash and merge instead.Also, the bot watches for comments from non-members that include
@bioconda/<team>and will automatically re-post them to notify the addressed<team>.