-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update bedtools to 2.31.0 #40802
Update bedtools to 2.31.0 #40802
Conversation
Update checksum to reflect the re-released upstream tarball. Remove `run` dependencies, which will be detected automatically.
Ugh, this time the upstream tarball is full of AppleDouble files, which have again foiled the tarball content hoisting:
So it may need to be regenerated once again. |
Do this conditionally, because bedtools-2.31.0.tar.gz variously containing .DS_Store and ._bedtools2 is an anomaly -- future release tarballs will likely revert to being cleanly hoistable.
83232c4
to
1c71ade
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Not only might the AppleDouble droppings issue be fixed in future bedtools release tarballs, but it has different effects on Linux and macOS: on macOS the extra files do not prevent conda-build's hoisting behaviour. Thus the Hence with the current upstream tarball (which upstream has not yet regenerated again, so we may wish to work around the problem rather than wait), the |
What is the @bioconda/core policy on stripping executables? Bedtools is a C++ executable. In the macOS build, This has been the case for a while: see the Anaconda bedtools file listing in which Linux packages are ~15 MB while macOS ones are ~1 MB. So Linux downloads and installations are arguably unnecessarily bloated. In fact, it appears to have started with bedtools 2.28 — so perhaps there is a Makefile setting that changed then that we can change back. |
Remove BT_CXXFLAGS from bioconda's build settings. We do not want -g as that bloats the executables (on Linux especially), and we do not need -O2 as conda-build's CXXFLAGS already provides suitable optimisation settings.
8cdea28
to
99d578d
Compare
Package(s) built on Azure are ready for inspection:
You may also use
Docker image(s) built (images are in the LinuxArtifacts zip file above):
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jmarshall!
Regarding stripping executables, there's no real policy there. We kind of assume there's a good reason that debug information is included if it's in there so we generally don't strip it out. |
@dpryan79: Thanks. In this case, the Makefile change adding |
Update checksum (again) to reflect the re-released upstream tarball. Remove
run
dependencies, which will be detected automatically.Please read the guidelines for Bioconda recipes before opening a pull request (PR).
@BiocondaBot please add label
command.@bioconda/core
in a comment.Please use the following BiocondaBot commands:
Everyone has access to the following BiocondaBot commands, which can be given in a comment:
@BiocondaBot please update
@BiocondaBot please add label
please review & merge
label.@BiocondaBot please fetch artifacts
You can use this to test packages locally.
For members of the Bioconda project, the following command is also available:
@BiocondaBot please merge
Someone must approve a PR first!
This reduces CI build time by reusing built artifacts.
Also, the bot watches for comments from non-members that include
@bioconda/<team>
and will automatically re-post them to notify the addressed<team>
.