Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bedtools to 2.31.0 #40802

Merged
merged 3 commits into from
May 9, 2023
Merged

Conversation

jmarshall
Copy link
Member

Update checksum (again) to reflect the re-released upstream tarball. Remove run dependencies, which will be detected automatically.


Please read the guidelines for Bioconda recipes before opening a pull request (PR).

  • If this PR adds or updates a recipe, use "Add" or "Update" appropriately as the first word in its title.
  • New recipes not directly relevant to the biological sciences need to be submitted to the conda-forge channel instead of Bioconda.
  • PRs require reviews prior to being merged. Once your PR is passing tests and ready to be merged, please issue the @BiocondaBot please add label command.
  • Please post questions on Gitter or ping @bioconda/core in a comment.
Please use the following BiocondaBot commands:

Everyone has access to the following BiocondaBot commands, which can be given in a comment:

@BiocondaBot please update Merge the master branch into a PR.
@BiocondaBot please add label Add the please review & merge label.
@BiocondaBot please fetch artifacts Post links to CI-built packages/containers.
You can use this to test packages locally.

For members of the Bioconda project, the following command is also available:

@BiocondaBot please merge Upload built packages/containers and merge a PR.
Someone must approve a PR first!
This reduces CI build time by reusing built artifacts.

Also, the bot watches for comments from non-members that include @bioconda/<team> and will automatically re-post them to notify the addressed <team>.

Update checksum to reflect the re-released upstream tarball.
Remove `run` dependencies, which will be detected automatically.
@jmarshall jmarshall mentioned this pull request May 4, 2023
@jmarshall
Copy link
Member Author

Ugh, this time the upstream tarball is full of AppleDouble files, which have again foiled the tarball content hoisting:

2023-05-04T23:54:48.2071461Z 23:54:37 �[32mBIOCONDA INFO�[0m (OUT) .
2023-05-04T23:54:48.2072063Z 23:54:37 �[32mBIOCONDA INFO�[0m (OUT) ..
2023-05-04T23:54:48.2072381Z 23:54:37 �[32mBIOCONDA INFO�[0m (OUT) ._bedtools2    # <--
2023-05-04T23:54:48.2072613Z 23:54:37 �[32mBIOCONDA INFO�[0m (OUT) bedtools2

So it may need to be regenerated once again.

Do this conditionally, because bedtools-2.31.0.tar.gz variously
containing .DS_Store and ._bedtools2 is an anomaly -- future release
tarballs will likely revert to being cleanly hoistable.
@BiocondaBot

This comment was marked as outdated.

@jmarshall
Copy link
Member Author

jmarshall commented May 9, 2023

Not only might the AppleDouble droppings issue be fixed in future bedtools release tarballs, but it has different effects on Linux and macOS: on macOS the extra files do not prevent conda-build's hoisting behaviour. Thus the Hoisting prevented message appears in the Linux build log but not the macOS build log.

Hence with the current upstream tarball (which upstream has not yet regenerated again, so we may wish to work around the problem rather than wait), the cd bedtools2 is required on Linux and required not to be done on macOS — so the if condition is required.

@jmarshall
Copy link
Member Author

What is the @bioconda/core policy on stripping executables?

Bedtools is a C++ executable. In the macOS build, bedtools is 2.2 MB and after stripping is 1.6 MB. In the Linux build, bedtools is 50 MB and after stripping drops to 2 MB.

This has been the case for a while: see the Anaconda bedtools file listing in which Linux packages are ~15 MB while macOS ones are ~1 MB. So Linux downloads and installations are arguably unnecessarily bloated.

In fact, it appears to have started with bedtools 2.28 — so perhaps there is a Makefile setting that changed then that we can change back.

Remove BT_CXXFLAGS from bioconda's build settings. We do not want -g as
that bloats the executables (on Linux especially), and we do not need -O2
as conda-build's CXXFLAGS already provides suitable optimisation settings.
@BiocondaBot
Copy link
Collaborator

Package(s) built on Azure are ready for inspection:

Arch Package Zip File
linux-64 bedtools-2.31.0-h468198e_0.tar.bz2 LinuxArtifacts
osx-64 bedtools-2.31.0-h61647ba_0.tar.bz2 OSXArtifacts

You may also use conda to install these after downloading and extracting the appropriate zip file. From the LinuxArtifacts or OSXArtifacts directories:

conda install -c ./packages <package name>

Docker image(s) built (images are in the LinuxArtifacts zip file above):

Package Tag Install with docker
bedtools 2.31.0--h468198e_0
showgzip -dc LinuxArtifacts/images/bedtools:2.31.0--h468198e_0.tar.gz | docker load

@jmarshall jmarshall added the please review & merge set to ask for merge label May 9, 2023
Copy link
Member

@bgruening bgruening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jmarshall!

@bgruening bgruening merged commit 4cfab91 into bioconda:master May 9, 2023
@jmarshall jmarshall deleted the bump/bedtools-2.31.0 branch May 9, 2023 09:06
@dpryan79
Copy link
Contributor

dpryan79 commented May 9, 2023

Regarding stripping executables, there's no real policy there. We kind of assume there's a good reason that debug information is included if it's in there so we generally don't strip it out.

@jmarshall
Copy link
Member Author

@dpryan79: Thanks. In this case, the Makefile change adding -g to release builds appears to have been accidentally committed along with something else, so I had no real qualms about removing it and will suggest to upstream that they revert that accidental change too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
please review & merge set to ask for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants