-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update bedtools 2.31 #40722
update bedtools 2.31 #40722
Conversation
Erroring at this step:
|
Aha I think the problem is we need to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool yeah that fixed it -- looks good to merge
Looks like osx is failing. Thanks @mjsteinbaugh for looking at it! |
Ah you're right, I'll try building locally to see if I can fix this |
Hmm yeah my recipe in koopa builds bedtools on macOS but conda is failing: Not sure what difference is causing the issue |
The need to add I was not able to reproduce the macOS failure locally. There are other problems with the upstream tarball that may have caused this failure, and I think the upstream tarball may be going to be re-released soon (which will also correct the .DS_Store problem). So I would suggest holding off with this until upstream have corrected or superseded their release. |
The upstream tarball has now been re-released, and this PR is probably superseded by #40802. We shall see whether the macOS failure has cured itself… |
For the record: the reason why the macOS build continued to fail is that on macOS
The replacement PR now does this conditionally. |
Describe your pull request here
Please read the guidelines for Bioconda recipes before opening a pull request (PR).
@BiocondaBot please add label
command.@bioconda/core
in a comment.Please use the following BiocondaBot commands:
Everyone has access to the following BiocondaBot commands, which can be given in a comment:
@BiocondaBot please update
@BiocondaBot please add label
please review & merge
label.@BiocondaBot please fetch artifacts
You can use this to test packages locally.
For members of the Bioconda project, the following command is also available:
@BiocondaBot please merge
Someone must approve a PR first!
This reduces CI build time by reusing built artifacts.
Also, the bot watches for comments from non-members that include
@bioconda/<team>
and will automatically re-post them to notify the addressed<team>
.