Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update bedtools 2.31 #40722

Closed
wants to merge 2 commits into from
Closed

update bedtools 2.31 #40722

wants to merge 2 commits into from

Conversation

bgruening
Copy link
Member

Describe your pull request here


Please read the guidelines for Bioconda recipes before opening a pull request (PR).

  • If this PR adds or updates a recipe, use "Add" or "Update" appropriately as the first word in its title.
  • New recipes not directly relevant to the biological sciences need to be submitted to the conda-forge channel instead of Bioconda.
  • PRs require reviews prior to being merged. Once your PR is passing tests and ready to be merged, please issue the @BiocondaBot please add label command.
  • Please post questions on Gitter or ping @bioconda/core in a comment.
Please use the following BiocondaBot commands:

Everyone has access to the following BiocondaBot commands, which can be given in a comment:

@BiocondaBot please update Merge the master branch into a PR.
@BiocondaBot please add label Add the please review & merge label.
@BiocondaBot please fetch artifacts Post links to CI-built packages/containers.
You can use this to test packages locally.

For members of the Bioconda project, the following command is also available:

@BiocondaBot please merge Upload built packages/containers and merge a PR.
Someone must approve a PR first!
This reduces CI build time by reusing built artifacts.

Also, the bot watches for comments from non-members that include @bioconda/<team> and will automatically re-post them to notify the addressed <team>.

@mjsteinbaugh mjsteinbaugh self-requested a review May 1, 2023 11:26
@mjsteinbaugh mjsteinbaugh self-assigned this May 1, 2023
@mjsteinbaugh
Copy link
Member

Erroring at this step:

2023-04-30T07:11:40.4468524Z 07:11:40 BIOCONDA INFO (OUT) make: *** No rule to make target 'install'.  Stop.

@mjsteinbaugh
Copy link
Member

Aha I think the problem is we need to cd to nested bedtools2 subdirectory before running make.

Copy link
Member

@mjsteinbaugh mjsteinbaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool yeah that fixed it -- looks good to merge

@bgruening
Copy link
Member Author

Looks like osx is failing. Thanks @mjsteinbaugh for looking at it!

@mjsteinbaugh
Copy link
Member

Ah you're right, I'll try building locally to see if I can fix this

@mjsteinbaugh
Copy link
Member

Hmm yeah my recipe in koopa builds bedtools on macOS but conda is failing:
https://github.com/acidgenomics/koopa/blob/main/lang/shell/bash/include/install/common/shared/bedtools.sh

Not sure what difference is causing the issue

@jmarshall
Copy link
Member

jmarshall commented May 2, 2023

The need to add cd bedtools2 is because the new upstream tarball contains .DS_Store files and the top-level one of those has prevented conda-build's usual “move the contents up” behaviour.

I was not able to reproduce the macOS failure locally. There are other problems with the upstream tarball that may have caused this failure, and I think the upstream tarball may be going to be re-released soon (which will also correct the .DS_Store problem).

So I would suggest holding off with this until upstream have corrected or superseded their release.

@jmarshall
Copy link
Member

The upstream tarball has now been re-released, and this PR is probably superseded by #40802. We shall see whether the macOS failure has cured itself…

@jmarshall
Copy link
Member

For the record: the reason why the macOS build continued to fail is that on macOS .DS_Store was ignored and did not cause the ‘usual ”move the contents up” behaviour’ to be suppressed. Hence cd bedtools2 was counterproductive on macOS:

2023-05-01T12:16:08.3334030Z 12:16:08 BIOCONDA INFO (ERR) /…/conda_build.sh: line 7: cd: bedtools2: No such file or directory

The replacement PR now does this conditionally.

@bgruening bgruening deleted the bedtools-2.31 branch July 31, 2023 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants