Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Babystep fix #600

Merged
merged 2 commits into from
May 8, 2020
Merged

Babystep fix #600

merged 2 commits into from
May 8, 2020

Conversation

xboxpro1
Copy link
Contributor

Babysteps are not working correct while printing over tft/rs232. Maybe the rs232 buffer is too busy.
Changed command from StoreCmd to mustStoreCmd. The Encoder did not work either. Also the Save Icon is obsolete, there is nothing to save..

This bug was found by nicolas81. Please see #584

Babysteps are not working correct while printing over tft/rs232. Maybe the rs232 buffer is too busy.
Changed command from StoreCmd to mustStoreCmd. The Encoder did not work either. Also the Save Icon is obsolete, there is nothing to save..

This bug was found by nicolas81. Please see <bigtreetech#584>
@radek8
Copy link
Contributor

radek8 commented Apr 30, 2020

Why do you want to delete the save button?

@xboxpro1
Copy link
Contributor Author

Hello, you can only save the babystep value when BABYSTEP_ZPROBE_OFFSET is enabled.
With the M500 command you change your Z Offset.
Please see https://marlinfw.org/docs/gcode/M290.html
BABYSTEP_ZPROBE_OFFSET disabled is recommended to avoid a side-effect.

@bigtreetech bigtreetech merged commit 308dc62 into bigtreetech:master May 8, 2020
jeffeb3 pushed a commit to jeffeb3/BIGTREETECH-TouchScreenFirmware that referenced this pull request Jul 20, 2020
Changed command from StoreCmd to mustStoreCmd. The Encoder did not work either. Also the Save Icon is obsolete, there is nothing to save..
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants