[solved] SKR E3 Mini + TFT35 E3 V3. babysteps doesn't work

[nicolas81]

Baby steps doesn't work : When you click + or - on the touch screen, the nozzle doesn't move.

[drphil3d]

I seem to be having this issue as well

[xboxpro1]

Hello, have you uncomment the line
//#define BABYSTEPPING in Configuration_adv.h / Marlin Firmware?
https://marlinfw.org/docs/configuration/configuration.html#babystepping

[nicolas81]

Yes of course. When I use Marlin mode, babystepping works well. I think that this issue come from TFT35 firmware.

[xboxpro1]

I can confirm that babystepping is working while printing. TFT35 E3 V3 + SKR V1.4.

[nicolas81]

I have SKR E3 MINI V1.2.
BabySteps are working correctly with the Marlin screen but not with BTT TFT E3 V3 screen for me...

[nicolas81]

I noticed today that babysteps are working correctly within the Classic Menu but not with in the Unified Menu.

[xboxpro1]

I think the baby step commands are not sent because the tft rs232 buffer is full.
try to edit BabyStep.c / TFT Firmware. Replace the command "storeCmd" with "mustStoreCmd" in BabyStep.c. The command occurs 4 times in the file. And the compile and flash TFT firmware.

[nicolas81]

I tried but I get this error :

[nicolas81]

I understood that mustStoreCmd is a void instead of storeCmd is bool function. So I will try this modification

[nicolas81]

Now, babysteps are working fine with + and - button. Thanks xboxpro1 !
Still remains problem with the encoder. As I am seeing in the code the encoder change the value of baby_step_value but doesn't send gcode command to the mother board. So the nozzle doesn't move with the encoder. And I don't understand the goal of the save button in this menu.

[xboxpro1]

why dont you fork marlin fix the issue and make a pull request. you are right the save button is obsolete. you can remove the button. change {ICON_EEPROM_SAVE, LABEL_EEPROM_SAVE} to
{ICON_BACKGROUND, LABEL_BACKGROUND}, i have altered ProbeOffset.c in my fork, now the nozzle is moving when i set the z offset. the encoder works too, maybe you can have a look.

i use this altered function form Move.c

AXIS zAxis = Z_AXIS;

void storeMoveCmdZ(AXIS xyz, int8_t direction) {
const char *xyzMoveCmd[] = {Z_GCODE};
// if invert is true, 'direction' multiplied by -1
storeCmd(xyzMoveCmd[xyz], (infoSettings.invert_axis[xyz] ? -direction : direction) * elementsUnit.ele[elementsUnit.cur]);
// update now axis be selected
zAxis = xyz;
}

And this code in the encoder loop

if(encoderPosition)
{
baby_step_value += elementsUnit.ele[elementsUnit.cur]*encoderPosition;
//this code ----> storeMoveCmdZ(Z_AXIS, encoderPosition > 0 ? 1 : -1);
encoderPosition = 0;
}

I'm just trying myself. i am not the creator or maintainer.

[xboxpro1]

maybe you must use "mustStoreCmd" in the function, because the printer is busy.
when i level the z offset the printer is idle and "storeCmd" is working fine.
void storeMoveCmdZ(AXIS xyz, int8_t direction) {
const char *xyzMoveCmd[] = {Z_GCODE};
// if invert is true, 'direction' multiplied by -1
mustStoreCmd(xyzMoveCmd[xyz], (infoSettings.invert_axis[xyz] ? -direction : direction) * elementsUnit.ele[elementsUnit.cur]);
// update now axis be selected
zAxis = xyz;
}

[xboxpro1]

oh i forgot you have to define in babystep.c
#define Z_GCODE "G1 Z%.2f\n" --- is not working

[nicolas81]

I think that I need to increase my skill in c++ programming before open a fork. I understand most of the code you give me above except %.2f. I guess it is a way to convert float into two digits float or something like that...but when I follow code with visual studio code I can't understand this.