Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Ukrainian language #1361

Merged
merged 6 commits into from
Dec 10, 2020
Merged

Improve Ukrainian language #1361

merged 6 commits into from
Dec 10, 2020

Conversation

0purple
Copy link
Contributor

@0purple 0purple commented Dec 8, 2020

No description provided.

Antti
Antti approved these changes Dec 9, 2020
View reviewed changes
Copy link
Contributor

@Antti Antti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Antti
Copy link
Contributor

Antti commented Dec 9, 2020

@vitaliy172 I think you also need to run buildroot/scripts/auto_gen_language_pack.py to generate the language packs.

@0purple
Copy link
Contributor Author

0purple commented Dec 10, 2020 •
edited
Loading

Yeah but autogenerated translations isn't that good. I'm native Ukrainian so I can translate a bit better

Antti
Antti reviewed Dec 10, 2020
View reviewed changes
Copy to SD Card root directory to update/Language Packs/language_uk.ini
@@ -202,8 +202,8 @@ label_move_speed:Швидкість (X Y Z)
label_knob_led:Підсвічування енкодера
label_knob_led_idle:Простій підсвічування енкодера
label_m0_pause:Пауза по команді M0
label_send_start_gcode:G-код перед друком
label_send_end_gcode:G-код після друку
label_send_start_gcode:Розпочати G-код перед друком
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think these are correct. You don't "begin" or "end" a G-code.
It toggles sending start/end g-code On or Off.

Copy link
Contributor Author

@0purple 0purple Dec 10, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

English version:
label_send_start_gcode:Start Gcode before print

label_send_end_gcode:End Gcode after print

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think "Start Gcode" means the gcode, which is exected on the start.
Same with the "End Gcode" - gcode, which is executed on the end.

@bigtreetech bigtreetech merged commit 858df63 into bigtreetech:master Dec 10, 2020
@Antti
Copy link
Contributor

Antti commented Dec 10, 2020

label_send_start_gcode and label_send_end_gcode are incorrect 😞

jeffeb3 pushed a commit to V1EngineeringInc/BIGTREETECH-TouchScreenFirmware that referenced this pull request Nov 10, 2021
@0purple
Improve Ukrainian language (bigtreetech#1361)
2d533b9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Antti Antti Antti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@0purple @Antti @bigtreetech @Msq001