Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate .d.ts file in build script #2653

Merged
merged 3 commits into from
Jun 20, 2024
Merged

Generate .d.ts file in build script #2653

merged 3 commits into from
Jun 20, 2024

Conversation

alexpetros
Copy link
Collaborator

@alexpetros alexpetros commented Jun 19, 2024 •
edited
Loading

Description

Add the typescript files to dist by putting the generation step in the build script. I also removed the jsconfig file and streamlined the tsc options.

Corresponding issue: #2629

Testing

  • Ran the dist script and verified that it output the types.

Checklist

  • I have read the contribution guidelines
  • I have targeted this PR against the correct branch (master for website changes, dev for
    source changes)
  • This is either a bugfix, a documentation update, or a new feature that has been explicitly
    approved via an issue
  • I ran the test suite locally (npm run test) and verified that it succeeded

@alexpetros alexpetros added the ready for review Issues that are ready to be considered for merging label Jun 19, 2024
Telroshan
Telroshan reviewed Jun 19, 2024
View reviewed changes
scripts/dist.sh Outdated Show resolved Hide resolved
@alexpetros
Streamline configuration options
5ec3b8d 
Delete the JSConfig so we don't have to un-specify options when checking
vs generating (and also to remove a config file). Steamline the options
by re-using the NPM commands.
@alexpetros
Remove type generating from dev script
5800440
@alexpetros alexpetros changed the base branch from master to dev June 19, 2024 22:43
@1cg 1cg merged commit e1143de into dev Jun 20, 2024
@alexpetros alexpetros deleted the generate-types-in-build branch June 20, 2024 20:42
@Telroshan Telroshan mentioned this pull request Jul 1, 2024
Closed
kubeden pushed a commit to kubeden/htmx that referenced this pull request Jul 11, 2024
@alexpetros @kubeden
Generate .d.ts file in build script (bigskysoftware#2653)
5177a37 
* Generate .d.ts file in build script

Resolves: bigskysoftware#2629

* Streamline configuration options

Delete the JSConfig so we don't have to un-specify options when checking
vs generating (and also to remove a config file). Steamline the options
by re-using the NPM commands.

* Remove type generating from dev script
@Telroshan Telroshan mentioned this pull request Aug 26, 2024
Open
Telroshan added a commit to Telroshan/htmx that referenced this pull request Sep 12, 2024
@Telroshan
Squashed personal changes
cc498bc 
commit 46b10d9
Author: Vincent <vichenzo-thebaud@hotmail.com>
Date:   Tue Jun 25 08:20:10 2024 +0200

    Fix error swapping default swap style over hx-swap #z186

commit 764cf9a
Author: Vincent <vichenzo-thebaud@hotmail.com>
Date:   Sun Jun 23 08:33:20 2024 +0200

    Restore dist bash call for Windows

commit 7d41292
Author: Vincent <vichenzo-thebaud@hotmail.com>
Date:   Sun Jun 23 08:24:29 2024 +0200

    Dist

commit e6a9114
Author: Vincent <vichenzo-thebaud@hotmail.com>
Date:   Sun Jun 23 08:22:11 2024 +0200

    Restore lint-fix npm command

commit 739f6a1
Merge: 940ce1c e1143de
Author: Vincent <vichenzo-thebaud@hotmail.com>
Date:   Sun Jun 23 08:17:16 2024 +0200

    Merge branch 'dev' into v2-merge

commit 940ce1c
Author: Vincent <vichenzo-thebaud@hotmail.com>
Date:   Sun Jun 23 08:16:43 2024 +0200

    readLayout/writeLayout JSDoc

commit 899f25f
Merge: 51ef0e2 6f83885
Author: Vincent <vichenzo-thebaud@hotmail.com>
Date:   Sun Jun 23 08:12:11 2024 +0200

    Merge branch 'upstream-master' into v2-merge

commit e1143de
Author: Alexander Petros <apetros15@gmail.com>
Date:   Thu Jun 20 13:18:47 2024 -0400

    Generate .d.ts file in build script (bigskysoftware#2653)

    * Generate .d.ts file in build script

    Resolves: bigskysoftware#2629

    * Streamline configuration options

    Delete the JSConfig so we don't have to un-specify options when checking
    vs generating (and also to remove a config file). Steamline the options
    by re-using the NPM commands.

    * Remove type generating from dev script

commit 51ef0e2
Merge: 2b95d79 601d16c
Author: Vincent <vichenzo-thebaud@hotmail.com>
Date:   Thu May 23 08:19:24 2024 +0200

    Merge branch 'dev' into v2-merge

commit 2b95d79
Author: Vincent <vichenzo-thebaud@hotmail.com>
Date:   Thu May 23 08:17:51 2024 +0200

    Add/remove request indicators in layout queues

commit 7eb8ebf
Author: Vincent <vichenzo-thebaud@hotmail.com>
Date:   Wed May 22 08:33:44 2024 +0200

    Revert "forceUseFormData htmx.ajax parameter #z176"

    This reverts commit 701c4a0.

commit 701c4a0
Author: Vincent <vichenzo-thebaud@hotmail.com>
Date:   Tue May 21 08:22:04 2024 +0200

    forceUseFormData htmx.ajax parameter #z176

commit 9355c29
Author: Vincent <vichenzo-thebaud@hotmail.com>
Date:   Tue May 21 07:50:56 2024 +0200

    Dist

commit 5d1211a
Merge: 6012f74 12675fd
Author: Vincent <vichenzo-thebaud@hotmail.com>
Date:   Tue May 21 07:39:41 2024 +0200

    Merge branch 'dev' into v2-merge

commit 6012f74
Author: Vincent <vichenzo-thebaud@hotmail.com>
Date:   Mon Apr 29 08:58:23 2024 +0200

    Dist

commit 36a6181
Author: Vincent <vichenzo-thebaud@hotmail.com>
Date:   Sun Apr 28 15:40:32 2024 +0200

    Fix boolean checkboxes values in form

commit 9d65265
Author: Vincent <vichenzo-thebaud@hotmail.com>
Date:   Sat Apr 27 10:19:41 2024 +0200

    Update README.md

commit 66300a1
Author: Vincent <vichenzo-thebaud@hotmail.com>
Date:   Sat Apr 27 10:07:30 2024 +0200

    Restored my changes #z143

commit 9e4cd2b
Merge: b176784 dc93911
Author: Vincent <vichenzo-thebaud@hotmail.com>
Date:   Fri Apr 26 09:00:41 2024 +0200

    Merge branch 'dev' into v2-merge
Telroshan added a commit to Telroshan/htmx that referenced this pull request Sep 12, 2024
@Telroshan
Squashed personal changes
5c8dbb2 
commit 46b10d9
Author: Vincent <vichenzo-thebaud@hotmail.com>
Date:   Tue Jun 25 08:20:10 2024 +0200

    Fix error swapping default swap style over hx-swap #z186

commit 764cf9a
Author: Vincent <vichenzo-thebaud@hotmail.com>
Date:   Sun Jun 23 08:33:20 2024 +0200

    Restore dist bash call for Windows

commit 7d41292
Author: Vincent <vichenzo-thebaud@hotmail.com>
Date:   Sun Jun 23 08:24:29 2024 +0200

    Dist

commit e6a9114
Author: Vincent <vichenzo-thebaud@hotmail.com>
Date:   Sun Jun 23 08:22:11 2024 +0200

    Restore lint-fix npm command

commit 739f6a1
Merge: 940ce1c e1143de
Author: Vincent <vichenzo-thebaud@hotmail.com>
Date:   Sun Jun 23 08:17:16 2024 +0200

    Merge branch 'dev' into v2-merge

commit 940ce1c
Author: Vincent <vichenzo-thebaud@hotmail.com>
Date:   Sun Jun 23 08:16:43 2024 +0200

    readLayout/writeLayout JSDoc

commit 899f25f
Merge: 51ef0e2 6f83885
Author: Vincent <vichenzo-thebaud@hotmail.com>
Date:   Sun Jun 23 08:12:11 2024 +0200

    Merge branch 'upstream-master' into v2-merge

commit e1143de
Author: Alexander Petros <apetros15@gmail.com>
Date:   Thu Jun 20 13:18:47 2024 -0400

    Generate .d.ts file in build script (bigskysoftware#2653)

    * Generate .d.ts file in build script

    Resolves: bigskysoftware#2629

    * Streamline configuration options

    Delete the JSConfig so we don't have to un-specify options when checking
    vs generating (and also to remove a config file). Steamline the options
    by re-using the NPM commands.

    * Remove type generating from dev script

commit 51ef0e2
Merge: 2b95d79 601d16c
Author: Vincent <vichenzo-thebaud@hotmail.com>
Date:   Thu May 23 08:19:24 2024 +0200

    Merge branch 'dev' into v2-merge

commit 2b95d79
Author: Vincent <vichenzo-thebaud@hotmail.com>
Date:   Thu May 23 08:17:51 2024 +0200

    Add/remove request indicators in layout queues

commit 7eb8ebf
Author: Vincent <vichenzo-thebaud@hotmail.com>
Date:   Wed May 22 08:33:44 2024 +0200

    Revert "forceUseFormData htmx.ajax parameter #z176"

    This reverts commit 701c4a0.

commit 701c4a0
Author: Vincent <vichenzo-thebaud@hotmail.com>
Date:   Tue May 21 08:22:04 2024 +0200

    forceUseFormData htmx.ajax parameter #z176

commit 9355c29
Author: Vincent <vichenzo-thebaud@hotmail.com>
Date:   Tue May 21 07:50:56 2024 +0200

    Dist

commit 5d1211a
Merge: 6012f74 12675fd
Author: Vincent <vichenzo-thebaud@hotmail.com>
Date:   Tue May 21 07:39:41 2024 +0200

    Merge branch 'dev' into v2-merge

commit 6012f74
Author: Vincent <vichenzo-thebaud@hotmail.com>
Date:   Mon Apr 29 08:58:23 2024 +0200

    Dist

commit 36a6181
Author: Vincent <vichenzo-thebaud@hotmail.com>
Date:   Sun Apr 28 15:40:32 2024 +0200

    Fix boolean checkboxes values in form

commit 9d65265
Author: Vincent <vichenzo-thebaud@hotmail.com>
Date:   Sat Apr 27 10:19:41 2024 +0200

    Update README.md

commit 66300a1
Author: Vincent <vichenzo-thebaud@hotmail.com>
Date:   Sat Apr 27 10:07:30 2024 +0200

    Restored my changes #z143

commit 9e4cd2b
Merge: b176784 dc93911
Author: Vincent <vichenzo-thebaud@hotmail.com>
Date:   Fri Apr 26 09:00:41 2024 +0200

    Merge branch 'dev' into v2-merge

Support multiple extended selectors for hx-include #z167
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Telroshan Telroshan Telroshan left review comments

Assignees
No one assigned
Labels
ready for review Issues that are ready to be considered for merging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexpetros @Telroshan @1cg