Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2.0.0 - Missing dist/htmx.d.ts #2629

Closed
jacob-ebey opened this issue Jun 17, 2024 · 4 comments
Closed

2.0.0 - Missing dist/htmx.d.ts #2629

jacob-ebey opened this issue Jun 17, 2024 · 4 comments
Labels
2.0 bug Something isn't working

Comments

@jacob-ebey
Copy link
Contributor

package.json has the the types field defined as dist/htmx.d.ts but that file is not published to npm.
@Telroshan Telroshan added bug Something isn't working 2.0 labels Jun 18, 2024
@1cg
Copy link
Contributor

1cg commented Jun 18, 2024

Sorry, will be in the next release (early next week) @alexpetros is fixing!

@1cg 1cg mentioned this issue Jun 18, 2024
Open
alexpetros added a commit that referenced this issue Jun 19, 2024
@alexpetros
Generate .d.ts file in build script
2ee6157 
Resolves: #2629
@alexpetros alexpetros mentioned this issue Jun 19, 2024
Merged
4 tasks
@yp05327 yp05327 mentioned this issue Jun 20, 2024
Merged
@silverwind silverwind mentioned this issue Jul 10, 2024
Merged
kubeden pushed a commit to kubeden/htmx that referenced this issue Jul 11, 2024
@alexpetros @kubeden
Generate .d.ts file in build script (bigskysoftware#2653)
5177a37 
* Generate .d.ts file in build script

Resolves: bigskysoftware#2629

* Streamline configuration options

Delete the JSConfig so we don't have to un-specify options when checking
vs generating (and also to remove a config file). Steamline the options
by re-using the NPM commands.

* Remove type generating from dev script
@1cg 1cg closed this as completed in e1143de Jul 12, 2024
@jacob-ebey
Copy link
Contributor Author

jacob-ebey commented Jul 12, 2024 •
edited
Loading

Please re-open. Type issues still exist due to use of a ".js" MJS file being pointed to by a CJS package.json. You have two options:

  • rename the dist/htmx.esm.js to dist/htmx.esm.mjs and update the main file accordingly
  • or add "type": "module" to the package.json so ".js" means MJS.

@Telroshan Telroshan reopened this Jul 13, 2024
@alexpetros
Copy link
Collaborator

alexpetros commented Jul 13, 2024 •
edited
Loading

A while back I added "type": "module" to the package.json and it caused some issues for webpack builds: #1968

@alexpetros
Copy link
Collaborator

Regardless, that is a separate issue, so please open a new one.

@alexpetros alexpetros mentioned this issue Jul 13, 2024
Open
4 tasks
Telroshan added a commit to Telroshan/htmx that referenced this issue Sep 12, 2024
@Telroshan
Squashed personal changes
cc498bc 
commit 46b10d9
Author: Vincent <vichenzo-thebaud@hotmail.com>
Date:   Tue Jun 25 08:20:10 2024 +0200

    Fix error swapping default swap style over hx-swap #z186

commit 764cf9a
Author: Vincent <vichenzo-thebaud@hotmail.com>
Date:   Sun Jun 23 08:33:20 2024 +0200

    Restore dist bash call for Windows

commit 7d41292
Author: Vincent <vichenzo-thebaud@hotmail.com>
Date:   Sun Jun 23 08:24:29 2024 +0200

    Dist

commit e6a9114
Author: Vincent <vichenzo-thebaud@hotmail.com>
Date:   Sun Jun 23 08:22:11 2024 +0200

    Restore lint-fix npm command

commit 739f6a1
Merge: 940ce1c e1143de
Author: Vincent <vichenzo-thebaud@hotmail.com>
Date:   Sun Jun 23 08:17:16 2024 +0200

    Merge branch 'dev' into v2-merge

commit 940ce1c
Author: Vincent <vichenzo-thebaud@hotmail.com>
Date:   Sun Jun 23 08:16:43 2024 +0200

    readLayout/writeLayout JSDoc

commit 899f25f
Merge: 51ef0e2 6f83885
Author: Vincent <vichenzo-thebaud@hotmail.com>
Date:   Sun Jun 23 08:12:11 2024 +0200

    Merge branch 'upstream-master' into v2-merge

commit e1143de
Author: Alexander Petros <apetros15@gmail.com>
Date:   Thu Jun 20 13:18:47 2024 -0400

    Generate .d.ts file in build script (bigskysoftware#2653)

    * Generate .d.ts file in build script

    Resolves: bigskysoftware#2629

    * Streamline configuration options

    Delete the JSConfig so we don't have to un-specify options when checking
    vs generating (and also to remove a config file). Steamline the options
    by re-using the NPM commands.

    * Remove type generating from dev script

commit 51ef0e2
Merge: 2b95d79 601d16c
Author: Vincent <vichenzo-thebaud@hotmail.com>
Date:   Thu May 23 08:19:24 2024 +0200

    Merge branch 'dev' into v2-merge

commit 2b95d79
Author: Vincent <vichenzo-thebaud@hotmail.com>
Date:   Thu May 23 08:17:51 2024 +0200

    Add/remove request indicators in layout queues

commit 7eb8ebf
Author: Vincent <vichenzo-thebaud@hotmail.com>
Date:   Wed May 22 08:33:44 2024 +0200

    Revert "forceUseFormData htmx.ajax parameter #z176"

    This reverts commit 701c4a0.

commit 701c4a0
Author: Vincent <vichenzo-thebaud@hotmail.com>
Date:   Tue May 21 08:22:04 2024 +0200

    forceUseFormData htmx.ajax parameter #z176

commit 9355c29
Author: Vincent <vichenzo-thebaud@hotmail.com>
Date:   Tue May 21 07:50:56 2024 +0200

    Dist

commit 5d1211a
Merge: 6012f74 12675fd
Author: Vincent <vichenzo-thebaud@hotmail.com>
Date:   Tue May 21 07:39:41 2024 +0200

    Merge branch 'dev' into v2-merge

commit 6012f74
Author: Vincent <vichenzo-thebaud@hotmail.com>
Date:   Mon Apr 29 08:58:23 2024 +0200

    Dist

commit 36a6181
Author: Vincent <vichenzo-thebaud@hotmail.com>
Date:   Sun Apr 28 15:40:32 2024 +0200

    Fix boolean checkboxes values in form

commit 9d65265
Author: Vincent <vichenzo-thebaud@hotmail.com>
Date:   Sat Apr 27 10:19:41 2024 +0200

    Update README.md

commit 66300a1
Author: Vincent <vichenzo-thebaud@hotmail.com>
Date:   Sat Apr 27 10:07:30 2024 +0200

    Restored my changes #z143

commit 9e4cd2b
Merge: b176784 dc93911
Author: Vincent <vichenzo-thebaud@hotmail.com>
Date:   Fri Apr 26 09:00:41 2024 +0200

    Merge branch 'dev' into v2-merge
Telroshan added a commit to Telroshan/htmx that referenced this issue Sep 12, 2024
@Telroshan
Squashed personal changes
5c8dbb2 
commit 46b10d9
Author: Vincent <vichenzo-thebaud@hotmail.com>
Date:   Tue Jun 25 08:20:10 2024 +0200

    Fix error swapping default swap style over hx-swap #z186

commit 764cf9a
Author: Vincent <vichenzo-thebaud@hotmail.com>
Date:   Sun Jun 23 08:33:20 2024 +0200

    Restore dist bash call for Windows

commit 7d41292
Author: Vincent <vichenzo-thebaud@hotmail.com>
Date:   Sun Jun 23 08:24:29 2024 +0200

    Dist

commit e6a9114
Author: Vincent <vichenzo-thebaud@hotmail.com>
Date:   Sun Jun 23 08:22:11 2024 +0200

    Restore lint-fix npm command

commit 739f6a1
Merge: 940ce1c e1143de
Author: Vincent <vichenzo-thebaud@hotmail.com>
Date:   Sun Jun 23 08:17:16 2024 +0200

    Merge branch 'dev' into v2-merge

commit 940ce1c
Author: Vincent <vichenzo-thebaud@hotmail.com>
Date:   Sun Jun 23 08:16:43 2024 +0200

    readLayout/writeLayout JSDoc

commit 899f25f
Merge: 51ef0e2 6f83885
Author: Vincent <vichenzo-thebaud@hotmail.com>
Date:   Sun Jun 23 08:12:11 2024 +0200

    Merge branch 'upstream-master' into v2-merge

commit e1143de
Author: Alexander Petros <apetros15@gmail.com>
Date:   Thu Jun 20 13:18:47 2024 -0400

    Generate .d.ts file in build script (bigskysoftware#2653)

    * Generate .d.ts file in build script

    Resolves: bigskysoftware#2629

    * Streamline configuration options

    Delete the JSConfig so we don't have to un-specify options when checking
    vs generating (and also to remove a config file). Steamline the options
    by re-using the NPM commands.

    * Remove type generating from dev script

commit 51ef0e2
Merge: 2b95d79 601d16c
Author: Vincent <vichenzo-thebaud@hotmail.com>
Date:   Thu May 23 08:19:24 2024 +0200

    Merge branch 'dev' into v2-merge

commit 2b95d79
Author: Vincent <vichenzo-thebaud@hotmail.com>
Date:   Thu May 23 08:17:51 2024 +0200

    Add/remove request indicators in layout queues

commit 7eb8ebf
Author: Vincent <vichenzo-thebaud@hotmail.com>
Date:   Wed May 22 08:33:44 2024 +0200

    Revert "forceUseFormData htmx.ajax parameter #z176"

    This reverts commit 701c4a0.

commit 701c4a0
Author: Vincent <vichenzo-thebaud@hotmail.com>
Date:   Tue May 21 08:22:04 2024 +0200

    forceUseFormData htmx.ajax parameter #z176

commit 9355c29
Author: Vincent <vichenzo-thebaud@hotmail.com>
Date:   Tue May 21 07:50:56 2024 +0200

    Dist

commit 5d1211a
Merge: 6012f74 12675fd
Author: Vincent <vichenzo-thebaud@hotmail.com>
Date:   Tue May 21 07:39:41 2024 +0200

    Merge branch 'dev' into v2-merge

commit 6012f74
Author: Vincent <vichenzo-thebaud@hotmail.com>
Date:   Mon Apr 29 08:58:23 2024 +0200

    Dist

commit 36a6181
Author: Vincent <vichenzo-thebaud@hotmail.com>
Date:   Sun Apr 28 15:40:32 2024 +0200

    Fix boolean checkboxes values in form

commit 9d65265
Author: Vincent <vichenzo-thebaud@hotmail.com>
Date:   Sat Apr 27 10:19:41 2024 +0200

    Update README.md

commit 66300a1
Author: Vincent <vichenzo-thebaud@hotmail.com>
Date:   Sat Apr 27 10:07:30 2024 +0200

    Restored my changes #z143

commit 9e4cd2b
Merge: b176784 dc93911
Author: Vincent <vichenzo-thebaud@hotmail.com>
Date:   Fri Apr 26 09:00:41 2024 +0200

    Merge branch 'dev' into v2-merge

Support multiple extended selectors for hx-include #z167
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
2.0 bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@1cg @jacob-ebey @Telroshan @alexpetros