Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Big PR with multiple validations - [DO NOT MERGE YET] #169

Merged
merged 21 commits into from
Jul 30, 2024
Merged

Big PR with multiple validations - [DO NOT MERGE YET] #169

merged 21 commits into from
Jul 30, 2024

Conversation

ypriverol
Copy link
Member

@ypriverol ypriverol commented Jul 28, 2024

  • Change the logic of validation, by default everything is validated, and three variables are now introduced to skip some of the validations:
    • --skip_ms_validation
    • --skip_factor_validation
    • --skip_experimental_design_validation

Factor values columns validation:

  • If factor values are not provided raise an error.
  • If the factor values are absent in the characteristics or comments raise an error.
  • If the values in the factor value column and their corresponding counterpart are different raise an error.

Experimental design validation:

  • If the data file and assay name combination are not unique raise an error.
  • If source name has the same comment[technical replicate], comment[biological replicate], comment[label], comment[fraction identifier]

Copy link

Python linting (black) is failing

To keep the code consistent with lots of contributors, we run automated code consistency checks.
To fix this CI test, please run:

  • Install black: pip install black
  • Fix formatting errors in your pipeline: black .
    Once you push these changes the test should pass, and you can hide this comment 👍
    We highly recommend setting up Black in your code editor so that this formatting is done automatically on save. Ask about it on Slack for help!
    Thanks again for your contribution!

@ypriverol ypriverol changed the title Big PR with multiple validations Big PR with multiple validations - [DO NOT MERGE YET] Jul 28, 2024
@ypriverol
Copy link
Member Author

Related to issue: bigbio/quantms#384

@ypriverol ypriverol self-assigned this Jul 28, 2024
Copy link
Collaborator

@jpfeuffer jpfeuffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks definitely safer than before.

@ypriverol ypriverol merged commit b58f9dd into main Jul 30, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants