-
Notifications
You must be signed in to change notification settings - Fork 130
MNT: fix ruff issue E712 #981
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
DimitriPapadopoulos
commented
Apr 14, 2023
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #981 +/- ##
=======================================
Coverage 83.41% 83.41%
=======================================
Files 38 38
Lines 4287 4287
Branches 1100 1100
=======================================
Hits 3576 3576
Misses 515 515
Partials 196 196
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
E712 Comparison to `False` should be `cond is False` E712 Comparison to `True` should be `cond is True`
c9f90e3 to
2ccd4f3
Compare
|
Not sure about this new error one while building docs: Changes under "Install extras":
It has to be related to the |
|
Indeed, the error looks like an effect of executablebooks/jupyter-cache#93, which breaks compatibility with SQLAlchemy < 1.4.0. Why is SQLAlchemy pinned to 1.3? |
We require SQLAlchemy < 1.4.0. However, jupyter_cache 0.6.0 relies on SQLAlchemy >= 1.4.0: executablebooks/jupyter-cache#93 Avoid pulling jupyter_cache 0.6.0 for now.
296a407 to
a953821
Compare