Skip to content

Conversation

@DimitriPapadopoulos
Copy link
Contributor

E712 Comparison to `False` should be `cond is False`
E712 Comparison to `True` should be `cond is True`

@codecov
Copy link

codecov bot commented Apr 14, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (257aa8b) 83.41% compared to head (a953821) 83.41%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #981   +/-   ##
=======================================
  Coverage   83.41%   83.41%           
=======================================
  Files          38       38           
  Lines        4287     4287           
  Branches     1100     1100           
=======================================
  Hits         3576     3576           
  Misses        515      515           
  Partials      196      196           
Impacted Files Coverage Δ
bids/layout/layout.py 88.48% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@DimitriPapadopoulos DimitriPapadopoulos marked this pull request as ready for review April 14, 2023 07:24
	E712 Comparison to `False` should be `cond is False`
	E712 Comparison to `True` should be `cond is True`
@DimitriPapadopoulos
Copy link
Contributor Author

DimitriPapadopoulos commented Apr 22, 2023

Not sure about this new error one while building docs:

Running Sphinx v5.3.0

Exception occurred:
  File "/home/runner/work/pybids/pybids/virtenv/lib/python3.8/site-packages/jupyter_cache/cache/db.py", line 10, in <module>
    from sqlalchemy.orm import declarative_base, sessionmaker, validates
ImportError: cannot import name 'declarative_base' from 'sqlalchemy.orm' (/home/runner/work/pybids/pybids/virtenv/lib/python3.8/site-packages/sqlalchemy/orm/__init__.py)
The full traceback has been saved in /tmp/sphinx-err-797b1210.log, if you want to report the issue to the developers.
The full traceback has been saved in /tmp/sphinx-err-797b1210.log, if you want to report the issue to the developers.
Please also report this if it was a user error, so that a better error message can be provided next time.
A bug report can be filed in the tracker at <https://github.com/sphinx-doc/sphinx/issues>. Thanks!

Changes under "Install extras":

  • importlib_metadata 6.4.1 → 6.5.0
  • jupyter_cache 0.5.0 → 0.6.0
  • nbclient 0.5.13 → 0.7.3
  • myst_nb 0.17.1 → 0.17.2
  • psutil 5.9.4 → 5.9.5
  • Pygments 2.15.0 → 2.15.1
  • tornado 6.2 → 6.3

It has to be related to the jupyter_cache update.

@DimitriPapadopoulos
Copy link
Contributor Author

DimitriPapadopoulos commented Apr 22, 2023

Indeed, the error looks like an effect of executablebooks/jupyter-cache#93, which breaks compatibility with SQLAlchemy < 1.4.0. Why is SQLAlchemy pinned to 1.3?

We require SQLAlchemy < 1.4.0.

However, jupyter_cache 0.6.0 relies on SQLAlchemy >= 1.4.0:
executablebooks/jupyter-cache#93

Avoid pulling jupyter_cache 0.6.0 for now.
@effigies effigies merged commit df945f4 into bids-standard:master Apr 24, 2023
@DimitriPapadopoulos DimitriPapadopoulos deleted the E712 branch April 24, 2023 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants