Allow sqlalchemy before 2.0 #959
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Originally it was pinned this way in 17db824 but no clear indication was recorded on why that is needed. If sqlalchemy really follows semver then it should remain comaptible with all the way to 2.0 . Otherwise - it makes pybids not installable in an env which actually requires newer sqlalchemy (more plausing) like in our case see datalad/datalad-registry#141 (comment)
Collaborator
|
This will break. We rely on deprecated behavior that was removed in 1.4. xref #679 |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #959 +/- ##
==========================================
+ Coverage 86.35% 86.54% +0.19%
==========================================
Files 35 35
Lines 4023 4043 +20
Branches 974 974
==========================================
+ Hits 3474 3499 +25
+ Misses 355 353 -2
+ Partials 194 191 -3 see 6 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Collaborator
Author
|
sample failed tests from a pre-release (ubuntu-latest, 3.8, pip, ci_tests, PRE_PIP_FLAGS) so indeed would need into looking , probably starting from @candleindark do you have any immediate ideas/past experience related to this? |
Sorry, I don't have any immediate experience with this error. Some background information for you if you are not already aware about. SQLAlchemy 1.4 is a "transitional" version. You may want to use SQLAlchemy 2.0 style of working even in SQLAlchemy 1.4. For more information, please checkout "About this document" in https://docs.sqlalchemy.org/en/14/tutorial/index.html#sqlalchemy-1-4-2-0-tutorial. |
Collaborator
|
Our goal is to drop sqlalchemy altogether. It will take some time. |
This page may be useful for you. For that particular error, you may want to look into https://docs.sqlalchemy.org/en/14/changelog/migration_14.html#the-new-instance-conflicts-with-existing-identity-error-is-now-a-warning |
What are you going to replace it with? I always want to try https://www.edgedb.com/. |
Collaborator
Contributor
|
Some dependencies have started dropping support for SQLAlchemy 1.3, not necessarily on purpose: I bet this will keep popping up in the near future. |
Collaborator
|
Replaced by #985. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally it was pinned this way in
17db824
but no clear indication was recorded on why that is needed. If sqlalchemy really follows semver then it should remain comaptible with all the way to 2.0 .
Otherwise - it makes pybids not installable in an env which actually requires newer sqlalchemy (more plausing) like in our case see datalad/datalad-registry#141 (comment)