Skip to content

Add HUMMINGBIRD_FC305 #815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

LYNHQQ
Copy link

@LYNHQQ LYNHQQ commented Jun 9, 2025

Add TARGET HUMMINGBIRD_FC305

Summary by CodeRabbit

  • New Features
    • Added support for the HUMMINGBIRD_FC305 flight controller board, including configuration for sensors, SD card, OSD, and various hardware interfaces.
    • Default settings for receiver protocol, blackbox logging to SD card, and hardware pin assignments are now available for this board.

Copy link

coderabbitai bot commented Jun 9, 2025

Walkthrough

A new configuration header file for the HUMMINGBIRD_FC305 flight controller board has been added. This file defines the MCU, board identification, enabled sensors, peripheral interfaces, pin assignments, timer mappings, ADC and DMA settings, UART assignments, and other board-specific parameters.

Changes

File(s) Change Summary
configs/HUMMINGBIRD_FC305/config.h Added new configuration header defining MCU, board ID, sensor enablement, pin/timer mappings, peripheral instances, and defaults.

Possibly related PRs

Suggested reviewers

  • ot0tot
  • haslinghuis

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5aaf675 and 668f04a.

📒 Files selected for processing (1)
  • configs/HUMMINGBIRD_FC305/config.h (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • configs/HUMMINGBIRD_FC305/config.h
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary or `` to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (2)
configs/HUMMINGBIRD_FC305/config.h (2)

40-60: Trim trailing whitespace in pin definitions
The line for SPI2_NSS_PIN has a trailing space which may trigger warnings. Please apply:

-#define SPI2_NSS_PIN         PB12 
+#define SPI2_NSS_PIN         PB12

82-88: Align timer mapping formatting
The last entry has inconsistent spacing around the comma before -1. For consistency, consider:

-    TIMER_PIN_MAP( 5, GYRO_1_CLKIN_PIN , 1,  -1) 
+    TIMER_PIN_MAP( 5, GYRO_1_CLKIN_PIN, 1, -1)
📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ebc7aa2 and 5aaf675.

📒 Files selected for processing (1)
  • configs/HUMMINGBIRD_FC305/config.h (1 hunks)
🔇 Additional comments (12)
configs/HUMMINGBIRD_FC305/config.h (12)

1-20: License header included
The file correctly includes the GPLv3 header.


21-21: #pragma once is appropriate
Using #pragma once prevents multiple inclusions cleanly.


23-27: Verify BOARD and manufacturer IDs
Ensure that BOARD_NAME HUMMINGBIRD_FC305 and MANUFACTURER_ID HBRD adhere to existing naming conventions and will be recognized by the build system.


28-32: Sensor enabling macros are consistent
The USE_ACC, USE_ACC_SPI_ICM42688P, USE_GYRO, and USE_GYRO_SPI_ICM42688P macros correctly enable the intended sensors.


33-39: Peripheral feature macros look correct
Enabling barometer (DPS310), SD card (SPI), MAX7456 OSD, and gyro clock input aligns with the hardware design.


61-72: SPI pin mappings verified
SPI1–SPI3 clock, data in/out, and chip-select pins match the board schematic.


73-81: Other IO pin definitions look correct
GYRO_1_CLKIN, ADC channels, VTX power pin, and CS lines align with the hardware layout.


90-92: ADC configuration macros are correct
ADC_INSTANCE and ADC1_DMA_OPT are set appropriately for this board.


93-99: Verify UART assignments for ESC and RX
ESC sensor set to USART3 and serial receiver on USART6 should correspond to the defined pin mappings.


100-106: Confirm default feature scales
Default blackbox, RX protocol (CRSF), DShot bitbang, and meter scales (110/800) look reasonable—please verify these values against expected performance and calibration data.


107-109: Clock and beeper settings are valid
BEEPER_INVERTED and SYSTEM_HSE_MHZ 8 match the oscillator and wiring on this board.


110-112: Validate auxiliary IO configuration
Check that PINIO1_CONFIG 129 and PINIO1_BOX 40 correctly represent the VTX 9V power configuration and OSD box mapping.

LYNHQQ and others added 3 commits June 10, 2025 17:33
Co-authored-by: Mark Haslinghuis <mark@numloq.nl>
Co-authored-by: Mark Haslinghuis <mark@numloq.nl>
Co-authored-by: Mark Haslinghuis <mark@numloq.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants