-
Notifications
You must be signed in to change notification settings - Fork 161
Add HUMMINGBIRD_FC305 #815
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
WalkthroughA new configuration header file for the HUMMINGBIRD_FC305 flight controller board has been added. This file defines the MCU, board identification, enabled sensors, peripheral interfaces, pin assignments, timer mappings, ADC and DMA settings, UART assignments, and other board-specific parameters. Changes
Possibly related PRs
Suggested reviewers
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
configs/HUMMINGBIRD_FC305/config.h (2)
40-60
: Trim trailing whitespace in pin definitions
The line forSPI2_NSS_PIN
has a trailing space which may trigger warnings. Please apply:-#define SPI2_NSS_PIN PB12 +#define SPI2_NSS_PIN PB12
82-88
: Align timer mapping formatting
The last entry has inconsistent spacing around the comma before-1
. For consistency, consider:- TIMER_PIN_MAP( 5, GYRO_1_CLKIN_PIN , 1, -1) + TIMER_PIN_MAP( 5, GYRO_1_CLKIN_PIN, 1, -1)
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
configs/HUMMINGBIRD_FC305/config.h
(1 hunks)
🔇 Additional comments (12)
configs/HUMMINGBIRD_FC305/config.h (12)
1-20
: License header included
The file correctly includes the GPLv3 header.
21-21
: #pragma once is appropriate
Using#pragma once
prevents multiple inclusions cleanly.
23-27
: Verify BOARD and manufacturer IDs
Ensure thatBOARD_NAME HUMMINGBIRD_FC305
andMANUFACTURER_ID HBRD
adhere to existing naming conventions and will be recognized by the build system.
28-32
: Sensor enabling macros are consistent
TheUSE_ACC
,USE_ACC_SPI_ICM42688P
,USE_GYRO
, andUSE_GYRO_SPI_ICM42688P
macros correctly enable the intended sensors.
33-39
: Peripheral feature macros look correct
Enabling barometer (DPS310), SD card (SPI), MAX7456 OSD, and gyro clock input aligns with the hardware design.
61-72
: SPI pin mappings verified
SPI1–SPI3 clock, data in/out, and chip-select pins match the board schematic.
73-81
: Other IO pin definitions look correct
GYRO_1_CLKIN, ADC channels, VTX power pin, and CS lines align with the hardware layout.
90-92
: ADC configuration macros are correct
ADC_INSTANCE
andADC1_DMA_OPT
are set appropriately for this board.
93-99
: Verify UART assignments for ESC and RX
ESC sensor set toUSART3
and serial receiver onUSART6
should correspond to the defined pin mappings.
100-106
: Confirm default feature scales
Default blackbox, RX protocol (CRSF), DShot bitbang, and meter scales (110/800) look reasonable—please verify these values against expected performance and calibration data.
107-109
: Clock and beeper settings are valid
BEEPER_INVERTED
andSYSTEM_HSE_MHZ 8
match the oscillator and wiring on this board.
110-112
: Validate auxiliary IO configuration
Check thatPINIO1_CONFIG 129
andPINIO1_BOX 40
correctly represent the VTX 9V power configuration and OSD box mapping.
Co-authored-by: Mark Haslinghuis <mark@numloq.nl>
Co-authored-by: Mark Haslinghuis <mark@numloq.nl>
Co-authored-by: Mark Haslinghuis <mark@numloq.nl>
Add TARGET HUMMINGBIRD_FC305
Summary by CodeRabbit