-
Notifications
You must be signed in to change notification settings - Fork 161
Add HUMMINGBIRD_AIO255 #806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
WalkthroughA new configuration header file for the HUMMINGBIRD_AIO255 flight controller board has been added. This file defines the target MCU, enables specific sensors and peripherals, assigns pins for various functions, sets up timer mappings, configures ADC/I2C/SPI/UART instances, and specifies default device and meter settings. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant HUMMINGBIRD_AIO255 Board
participant Sensors (ICM42688P)
participant Flash (M25P16/W25Q128FV/W25N01G)
participant OSD (MAX7456)
participant Motors/LEDs
participant UART/I2C/SPI Peripherals
User->>HUMMINGBIRD_AIO255 Board: Power on / Initialize
HUMMINGBIRD_AIO255 Board->>Sensors (ICM42688P): Initialize via SPI4
HUMMINGBIRD_AIO255 Board->>Flash: Initialize via SPI3
HUMMINGBIRD_AIO255 Board->>OSD (MAX7456): Initialize via SPI2
HUMMINGBIRD_AIO255 Board->>Motors/LEDs: Configure pins and timers
HUMMINGBIRD_AIO255 Board->>UART/I2C/SPI Peripherals: Configure instances and assign pins
HUMMINGBIRD_AIO255 Board-->>User: Ready for operation
Possibly related PRs
Suggested reviewers
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
configs/HUMMINGBIRD_AIO255_AT32F435/config.h (1)
71-71
: Nit: Add space after inline comment delimiter.
Ensure there’s a space after//
for consistency and readability on the line:#define PINIO1_PIN PH3 // VTX 10V
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
configs/HUMMINGBIRD_AIO255_AT32F435/config.h
(1 hunks)
🔇 Additional comments (4)
configs/HUMMINGBIRD_AIO255_AT32F435/config.h (4)
1-41
: No concerns in header and core macros.
42-67
: No concerns in pin and peripheral definitions.Also applies to: 69-70, 72-83, 87-103
84-86
: Verify ADC DMA configuration.
Please confirm that theADC1_DMA_OPT
value12
matches the DMA channel/stream assignment forADC1
on the AT32F435G MCU.
104-106
: Confirm PINIO1 resource configuration.
Verify thatPINIO1_CONFIG
(129
) andPINIO1_BOX
(40
) correctly correspond to the PH3 pin function and resource mapping in the board definition.
Co-authored-by: ot0tot <36753790+ot0tot@users.noreply.github.com>
Co-authored-by: ot0tot <36753790+ot0tot@users.noreply.github.com>
Co-authored-by: ot0tot <36753790+ot0tot@users.noreply.github.com>
add HUMMINGBIRD_AIO255 target
Summary by CodeRabbit