replace cpx11 with cpx22 in e2e tests for hetzner - #1935
Conversation
Hetzner stopped orders for some servers https://docs.hetzner.cloud/changelog#2025-10-16-server-types-deprecated
|
Caution Review failedThe pull request is closed. WalkthroughUpdated numerous YAML examples, test manifests, and kustomization image tags: primarily changed Hetzner node pool Changes
Possibly related PRs
Suggested labels
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. 📜 Recent review detailsConfiguration used: Organization UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
bernardhalas
left a comment
There was a problem hiding this comment.
50% more expensive, but 4x as powerful.
LGTM
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In @docs/update/update.md:
- Line 54: The "Changing the Server Type" example currently shows the same value
for serverType in both old and new examples; update the example so the old and
new configurations differ (e.g., change the "old version" serverType from cpx22
to a prior type like cpx20 or change the "new version" to cpx32) so it actually
demonstrates a server type change; update all occurrences where serverType
remains identical in that example (the duplicated entries at the example block
referenced) to reflect a meaningful change.
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (10)
docs/contributing/local-testing.mddocs/getting-started/detailed-guide.mddocs/input-manifest/example.mddocs/input-manifest/external-templates.mddocs/input-manifest/providers/hetzner.mddocs/input-manifest/providers/on-prem.mddocs/llms-full.txtdocs/storage/storage-solution.mddocs/update/update.mdservices/manager/internal/service/watchers_test.go
✅ Files skipped from review due to trivial changes (2)
- docs/contributing/local-testing.md
- docs/llms-full.txt
🧰 Additional context used
🧠 Learnings (2)
📚 Learning: 2025-12-17T11:30:35.351Z
Learnt from: JKBGIT1
Repo: berops/claudie PR: 1921
File: manifests/testing-framework/test-sets/rolling-update-2/1.yaml:84-89
Timestamp: 2025-12-17T11:30:35.351Z
Learning: In Claudie manifests (manifests/testing-framework/test-sets/), node pools with names containing "ldbl" or used in the `loadBalancers.clusters.pools` section are load balancer node pools, not control plane or compute plane nodes. Load balancer node pools have different resource requirements and are not subject to the same CPU/memory specifications as master (control) and worker (compute) nodes.
Applied to files:
docs/input-manifest/example.mddocs/storage/storage-solution.mddocs/input-manifest/providers/on-prem.md
📚 Learning: 2025-08-13T14:22:14.668Z
Learnt from: Despire
Repo: berops/claudie PR: 1819
File: services/kuber/server/domain/utils/nodes/patch.go:230-237
Timestamp: 2025-08-13T14:22:14.668Z
Learning: In services/kuber/server/domain/utils/nodes/patch.go, the user Despire has observed that using "replace" operation for JSON-Patch on /spec/taints works fine on newly added taints in their testing environment, even though the JSON-Patch specification suggests "replace" should fail on missing fields.
Applied to files:
services/manager/internal/service/watchers_test.go
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: Run golangci-lint
- GitHub Check: gotest
- GitHub Check: build-and-push
🔇 Additional comments (7)
docs/input-manifest/providers/on-prem.md (1)
108-108: ✓ Appropriate server type upgrade for control plane pool.The change from
cpx11tocpx22correctly addresses the Hetzner server type deprecation.cpx22is a suitable replacement for control plane nodes and provides improved resource allocation compared to the deprecated type.docs/storage/storage-solution.md (1)
59-59: ✓ Consistent role-based server type upgrades across node pool examples.All server type updates correctly address Hetzner deprecation while maintaining appropriateness for each pool's role:
- Control (line 59):
cpx21→cpx22— suitable for control plane- Datastore (line 68):
cpx21→cpx22— adequate for persistence workloads with storage disk allocation- Compute (line 82):
cpx41→cpx42— upgrade supports compute workloads- Load balancer (line 95):
cpx21→cpx22— appropriate for load balancer roleThe changes maintain the logical resource hierarchy across pool types and the storage example remains coherent.
Also applies to: 68-68, 82-82, 95-95
docs/getting-started/detailed-guide.md (1)
342-342: ✓ Appropriate server type upgrade for bursting compute pool.The change from
cpx51tocpx52correctly addresses Hetzner deprecation and is well-suited for the bursting compute node pool. The upgrade provides improved resources for workload distribution and is compatible with the autoscaler configuration.docs/input-manifest/external-templates.md (1)
124-124: LGTM - Documentation updated to use available server types.The serverType updates from cpx11 to cpx22 across all three nodepools (control-htz, compute-1-htz, compute-2-htz) are consistent with the PR objective to replace deprecated Hetzner server types.
Also applies to: 138-138, 153-153
services/manager/internal/service/watchers_test.go (1)
319-319: LGTM - Test fixture updated to use available server type.The test data now uses cpx22 instead of the deprecated cpx11, ensuring tests run against valid Hetzner server types.
docs/input-manifest/providers/hetzner.md (1)
86-86: LGTM - Documentation examples updated consistently.All Hetzner provider examples now use cpx22 instead of the deprecated cpx11, covering both single-provider and multi-provider scenarios.
Also applies to: 100-100, 115-115, 174-174, 188-188, 202-202, 217-217
docs/input-manifest/example.md (1)
111-111: LGTM - Comprehensive example updated with available server types.All Hetzner nodepools in the example manifest now use cpx22, covering control, compute, autoscaled, and loadbalancer node pools.
Also applies to: 129-129, 143-143, 261-261
|
Merging this PR, since the e2e pipeline didn't fail on the Hetzner error but on #1920 |
This PR fixes the e2e pipeline because Hetzner stopped orders for some servers https://docs.hetzner.cloud/changelog#2025-10-16-server-types-deprecated
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.