Skip to content

fix: remove invalid serverType change in proxy-with-hetzner test set - #1973

Merged
samuelstolicny merged 2 commits into
masterfrom
fix/proxy-with-hetzner-test-set-1953
Feb 16, 2026
Merged

fix: remove invalid serverType change in proxy-with-hetzner test set#1973
samuelstolicny merged 2 commits into
masterfrom
fix/proxy-with-hetzner-test-set-1953

Conversation

@samuelstolicny

@samuelstolicny samuelstolicny commented Feb 11, 2026

Copy link
Copy Markdown
Member

Summary

  • Remove step 7.yaml from the proxy-with-hetzner test set which attempted to change serverType of the gcp-cmpt-nodes dynamic nodepool from e2-medium to e2-small, violating the immutability constraint for dynamic nodepools
  • Rename 8.yaml to 7.yaml to maintain sequential step numbering
  • Update kustomization.yaml to reflect the reduced test step count (8 -> 7 steps)

Fixes #1953

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Switched a test scenario’s infrastructure provider from GCP to Hetzner, updating node pool definitions and counts.
    • Removed an obsolete test manifest and trimmed the secret input list for the related test set, reducing included configuration files.

…1953)

Step 7.yaml attempted to change the serverType of the gcp-cmpt-nodes
dynamic nodepool from e2-medium to e2-small, which violates the
immutability constraint for dynamic nodepools. Remove the invalid step
and rename 8.yaml to 7.yaml to maintain sequential numbering.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Feb 11, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉


Walkthrough

Removed manifests/testing-framework/test-sets/proxy-with-hetzner/8.yaml and its reference in kustomization; updated 7.yaml to replace the GCP compute pool with a Hetzner compute pool (renamed and providerSpec values changed).

Changes

Cohort / File(s) Summary
Kustomization
manifests/testing-framework/kustomization.yaml
Removed test-sets/proxy-with-hetzner/8.yaml from the secretGenerator.files list for the proxy-with-hetzner secret.
Provider Migration
manifests/testing-framework/test-sets/proxy-with-hetzner/7.yaml
Replaced GCP compute component (gcp-cmpt-nodes) with Hetzner component (htz-cmpt-nodes); updated providerSpec fields (name, region/zone, serverType, image, storageDiskSize) and adjusted compute pool reference and count (2 → 1).
Test Set Removal
manifests/testing-framework/test-sets/proxy-with-hetzner/8.yaml
Deleted the InputManifest that defined providers, secrets, Hetzner/GCP node pools, Kubernetes cluster config, and pools mapping for the proxy-with-hetzner test set.

Possibly related PRs

🚥 Pre-merge checks | ✅ 6
✅ Passed checks (6 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: removing the invalid serverType modification that violated dynamic nodepool immutability constraints in the proxy-with-hetzner test set.
Linked Issues check ✅ Passed The PR fully implements the fix for issue #1953 by deleting invalid 7.yaml, renaming 8.yaml to 7.yaml, and updating kustomization.yaml to reflect the reduced step count.
Out of Scope Changes check ✅ Passed All changes directly address the scope of issue #1953: removing the invalid test step and updating related manifest files. No unrelated modifications detected.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Merge Conflict Detection ✅ Passed ✅ No merge conflicts detected when merging into master

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/proxy-with-hetzner-test-set-1953

Tip

Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@samuelstolicny samuelstolicny added the bug Something isn't working label Feb 11, 2026
@samuelstolicny
samuelstolicny marked this pull request as ready for review February 11, 2026 09:15
@samuelstolicny
samuelstolicny added this pull request to the merge queue Feb 16, 2026
Merged via the queue into master with commit 665544a Feb 16, 2026
8 checks passed
@samuelstolicny
samuelstolicny deleted the fix/proxy-with-hetzner-test-set-1953 branch February 16, 2026 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix invalid serverType change in proxy-with-hetzner test set

2 participants