Skip to content

feat: menambahkan @bellshade/ningali sebagai ganti folder server #297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
May 11, 2022
Merged

feat: menambahkan @bellshade/ningali sebagai ganti folder server #297

merged 12 commits into from
May 11, 2022

Conversation

reacto11mecha
Copy link
Collaborator

@reacto11mecha reacto11mecha commented Mar 17, 2022 •
edited by rahmatagungj
Loading

Deskripsi (Description)

  • saya menambahkan algoritma terbaru
  • saya memperbaiki algoritma yang sudah ada
  • saya menambahkan materi/sub materi belajar
  • saya memperbaiki materi/sub materi belajar
  • saya menambah dokumentasi
  • saya memperbaiki dokumentasi

Contributor Requirements (Syarat Kontributor)

  • saya sudah membaca (i have read) CONTRIBUTING dan sudah menyetujui semua
  • saya telah menambahkan docstring yang memberikan penjelasan maksud dari kode yang saya buat
  • saya menggunakan bahasa indonesia untuk memberikan penjelasan dari kode yang saya buat

Environment

saya menggunakan (im used):

  • os = linux

Testing

  • doctesting js
  • lint testing eslint

@auto-add-label auto-add-label bot added the enhancement New feature or request label Mar 17, 2022
@reacto11mecha reacto11mecha requested a review from a team March 17, 2022 07:37
@reacto11mecha reacto11mecha marked this pull request as draft March 20, 2022 10:01
@reacto11mecha
Copy link
Collaborator Author

Sementara di convert ke draft dulu, menunggu issue #215 dan #292 selesai dikerjakan dan di merge

@reacto11mecha
Copy link
Collaborator Author

Menunggu #308 selesai dikerjakan, setelah ini baru di ready for review lagi

@reacto11mecha reacto11mecha marked this pull request as ready for review May 11, 2022 06:56
@mergify mergify bot merged commit f0bddb4 into bellshade:main May 11, 2022
@reacto11mecha reacto11mecha deleted the migrate-ningali branch May 11, 2022 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nomadkode nomadkode nomadkode approved these changes

@rizkyikhwan rizkyikhwan rizkyikhwan approved these changes

@hasheemi hasheemi Awaiting requested review from hasheemi hasheemi is a code owner

@KimmyKx KimmyKx Awaiting requested review from KimmyKx KimmyKx is a code owner

@rolandowebdev rolandowebdev Awaiting requested review from rolandowebdev

@azqilana azqilana Awaiting requested review from azqilana

Assignees
No one assigned
Labels
enhancement New feature or request javascript file ready-to-merge request tim javascript untuk review js file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@reacto11mecha @nomadkode @rizkyikhwan