Skip to content

feat: menambahkan sistem ganti port pada webserver #292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Mar 21, 2022
Merged

feat: menambahkan sistem ganti port pada webserver #292

merged 8 commits into from
Mar 21, 2022

Conversation

LintangDev
Copy link
Collaborator

@LintangDev LintangDev commented Mar 10, 2022 •
edited
Loading

Closes

Deskripsi (Description)

  • saya menambahkan algoritma terbaru
  • saya memperbaiki algoritma yang sudah ada
  • saya menambahkan materi/sub materi belajar
  • saya memperbaiki materi/sub materi belajar
  • saya menambah dokumentasi
  • saya memperbaiki dokumentasi

Contributor Requirements (Syarat Kontributor)

  • saya sudah membaca (i have read) CONTRIBUTING dan sudah menyetujui semua
  • saya telah menambahkan docstring yang memberikan penjelasan maksud dari kode yang saya buat
  • saya menggunakan bahasa indonesia untuk memberikan penjelasan dari kode yang saya buat

Environment

saya menggunakan (im used):

  • os = windows

Testing

  • doctesting js
  • lint testing eslint

@LintangDev LintangDev changed the title :feat menambahkan sistem ganti port pada webserver feat: menambahkan sistem ganti port pada webserver Mar 10, 2022
@auto-add-label auto-add-label bot added the enhancement New feature or request label Mar 10, 2022
@dhafitf dhafitf self-requested a review March 11, 2022 00:19
This was referenced Mar 11, 2022
Closed
Closed
reacto11mecha
reacto11mecha requested changes Mar 11, 2022
View reviewed changes
Copy link
Collaborator

@reacto11mecha reacto11mecha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Konfigurasinya jangan pake file json, pake file .env aja. Takutnya kalo ada file port.json itu nanti malah masuk ke commitnya. Jangan lupa install dotenv juga sekalian nanti di tambahin di server/app.js.

Sekalian di file .gitignore nya di tambahin file .env biar ga ke track git nya

@reacto11mecha
Copy link
Collaborator

Progressnya udah sampe mana @LintangDev ?

@reacto11mecha reacto11mecha mentioned this pull request Mar 20, 2022
Merged
11 tasks
reacto11mecha
reacto11mecha requested changes Mar 20, 2022
View reviewed changes
Copy link
Collaborator

@reacto11mecha reacto11mecha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Untuk fungsionalitas, udah oke dan jalan pake node . maupun npm start. Sisanya tinggal penulisan aja yang kurang

reacto11mecha
reacto11mecha approved these changes Mar 20, 2022
View reviewed changes
Copy link
Collaborator

@reacto11mecha reacto11mecha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sip, LGTM 👍

@reacto11mecha reacto11mecha requested a review from a team March 20, 2022 10:33
reacto11mecha
reacto11mecha requested changes Mar 20, 2022
View reviewed changes
@mergify mergify bot merged commit 821aa05 into bellshade:main Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reacto11mecha reacto11mecha reacto11mecha approved these changes

@nomadkode nomadkode nomadkode approved these changes

@hasheemi hasheemi Awaiting requested review from hasheemi hasheemi is a code owner

@KimmyKx KimmyKx Awaiting requested review from KimmyKx KimmyKx is a code owner

@rolandowebdev rolandowebdev Awaiting requested review from rolandowebdev

@azqilana azqilana Awaiting requested review from azqilana

@rizkyikhwan rizkyikhwan Awaiting requested review from rizkyikhwan rizkyikhwan is a code owner

@dhafitf dhafitf Awaiting requested review from dhafitf

Assignees
No one assigned
Labels
enhancement New feature or request javascript file markdown files ready-to-merge request tim javascript untuk review js file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LintangDev @reacto11mecha @nomadkode