Skip to content

Menambahkan materi OOP Abstraction #255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 10, 2022
Merged

Menambahkan materi OOP Abstraction #255

merged 4 commits into from
Jan 10, 2022

Conversation

reacto11mecha
Copy link
Collaborator

Closes #223

Deskripsi (Description)

  • saya menambahkan algoritma terbaru
  • saya memperbaiki algoritma yang sudah ada
  • saya menambahkan materi/sub materi belajar
  • saya memperbaiki materi/sub materi belajar
  • saya menambah dokumentasi
  • saya memperbaiki dokumentasi

Contributor Requirements (Syarat Kontributor)

  • saya sudah membaca (i have read) CONTRIBUTING dan sudah menyetujui semua
  • saya telah menambahkan docstring yang memberikan penjelasan maksud dari kode yang saya buat
  • saya menggunakan bahasa indonesia untuk memberikan penjelasan dari kode yang saya buat

Environment

saya menggunakan (im used):

  • os = linux

Testing

  • doctesting js
  • lint testing eslint

@reacto11mecha reacto11mecha requested a review from a team January 10, 2022 10:17
wanrabbae
wanrabbae approved these changes Jan 10, 2022
View reviewed changes
Copy link
Collaborator

@wanrabbae wanrabbae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Udh bagus om. LGTM

KimmyKx
KimmyKx approved these changes Jan 10, 2022
View reviewed changes
Copy link
Collaborator

@KimmyKx KimmyKx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@reacto11mecha
Copy link
Collaborator Author

Hmm okey, tinggal di review dari sisi kebahasaan dari docsnya

@reacto11mecha reacto11mecha requested a review from dhafitf January 10, 2022 13:51
dhafitf
dhafitf approved these changes Jan 10, 2022
View reviewed changes
Copy link
Member

@dhafitf dhafitf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

rolandowebdev
rolandowebdev reviewed Jan 10, 2022
View reviewed changes
Copy link
Collaborator

@rolandowebdev rolandowebdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM🚀

@reacto11mecha
Copy link
Collaborator Author

Sip, kode aman docs aman tinggal di merge

@mergify mergify bot merged commit abb2821 into bellshade:main Jan 10, 2022
@reacto11mecha reacto11mecha deleted the class-abstraction branch January 21, 2022 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rolandowebdev rolandowebdev rolandowebdev approved these changes

@wanrabbae wanrabbae wanrabbae approved these changes

@dhafitf dhafitf dhafitf approved these changes

@KimmyKx KimmyKx KimmyKx approved these changes

@azqilana azqilana Awaiting requested review from azqilana

@hasheemi hasheemi Awaiting requested review from hasheemi hasheemi is a code owner

@rizkyikhwan rizkyikhwan Awaiting requested review from rizkyikhwan rizkyikhwan is a code owner

Assignees
No one assigned
Labels
javascript file markdown files ready-to-merge request tim javascript untuk review js file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Abstraction
5 participants
@reacto11mecha @rolandowebdev @wanrabbae @dhafitf @KimmyKx