Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: scope ci workflow #3907

Merged
merged 1 commit into from
Apr 17, 2021
Merged

ci: scope ci workflow #3907

merged 1 commit into from
Apr 17, 2021

Conversation

jef
Copy link
Member

@jef jef commented Apr 16, 2021

Description

Changes ci workflow to only run when:

  • A push to master happens
  • A pull request gets opened and it's base is master
    • This will also kick of sequential ci runs if the branch is updated (synchronized: GitHub's terminology)

This makes for deduping the checks ran.

@sampsyo
Copy link
Member

sampsyo commented Apr 17, 2021

Ah, that's very useful! So this will avoid the doubled runs for "push" and "pull request" on every PR? This seems great!! Thanks!

@jef
Copy link
Member Author

jef commented Apr 17, 2021

Exactly!

@jef jef merged commit 50163b3 into master Apr 17, 2021
@jef jef deleted the ci/update-workflow branch April 17, 2021 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants