Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: makes discussions more visible #3807

Merged
merged 6 commits into from
Apr 19, 2021
Merged

chore: makes discussions more visible #3807

merged 6 commits into from
Apr 19, 2021

Conversation

jef
Copy link
Member

@jef jef commented Dec 10, 2020

Description

I created a config.yml thats helps make Discussions more visible.

Example (from another repository):

image

Open links point to Discussions.

I have also removed feature request as it seems more fitting to have Discussions about a feature and then use the Issues for valid tickets/things being worked on.

@sampsyo
Copy link
Member

sampsyo commented Dec 11, 2020

Cool; thanks for getting this going!

FWIW, I do think it's cool to have tickets for feature requests as well as bugs in the tracker… but I get your intent to put vague "ideas" on the discussion board. Maybe we should keep the template around but just clarify that it's for cases where you know pretty much what you want and are ready to write a coherent proposal, whereas discussions are for when you just want to chat about an idea?

@jef
Copy link
Member Author

jef commented Dec 11, 2020

I think that's a great idea. I think I'll also adopt that! Perhaps I'll come up with some verbiage later today. If you think of something in the meantime, feel free to update or post here and I can put it in.

Thanks for the feedback 😀

@stale
Copy link

stale bot commented Apr 10, 2021

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Apr 10, 2021
@jef
Copy link
Member Author

jef commented Apr 14, 2021

What do we think, should we add this in?

@stale stale bot removed the stale label Apr 14, 2021
@sampsyo
Copy link
Member

sampsyo commented Apr 15, 2021

Oh yeah, sounds good to me! But maybe we should leave the Discourse link for now just to see how things go?

@jef
Copy link
Member Author

jef commented Apr 16, 2021

Oh yeah, sounds good to me! But maybe we should leave the Discourse link for now just to see how things go?

I agree!

@sampsyo
Copy link
Member

sampsyo commented Apr 16, 2021

Nice; looks pretty good to me! And I think the CI failures may be resolved my updating with master? In any case, I think it's about good to go.

@jef
Copy link
Member Author

jef commented Apr 16, 2021

And I think the CI failures may be resolved my updating with master

Not sure why, I can rerun if needed.

Also made this to help: #3907

@sampsyo
Copy link
Member

sampsyo commented Apr 17, 2021

Odd… just to be sure, maybe we should try merging #3907 first and seeing if that helps clear things up on this PR?

@jef
Copy link
Member Author

jef commented Apr 17, 2021

I also did a rebase. I didn't realize that this was roughly 300 commits behind. Probably had something to do with it 😅

@sampsyo
Copy link
Member

sampsyo commented Apr 17, 2021

Ah, that'd do it! LGTM, except that it looks like maybe the feature request template file might have gotten accidentally deleted?

@jef
Copy link
Member Author

jef commented Apr 18, 2021

Ah, good question. I removed it on purpose. Since the config.yaml will point folks to the Discussion board, they'll be able to discuss a feature in length. If we decide to pull it in, we can create put it on the board in a way we like.

This doesn't prohibit the user to define a feature request either way, but just leads them in the direction.

If you don't like this approach, I have no problem reverting.

@sampsyo
Copy link
Member

sampsyo commented Apr 18, 2021

Got it! I don't object, certainly. Here's a question, though: when a feature request eventually makes its way over from vague discussion to a concrete proposal, will we want to follow a template then? (One option might be to add an encouragement to do discussion ahead of time to the template itself.)

@jef
Copy link
Member Author

jef commented Apr 18, 2021

Aha, makes sense to me. The feature issue could definitely lose it's structure overtime, so that's good idea! I'll update.

@jef jef force-pushed the chore/issue-template branch from a8bfc23 to eca8962 Compare April 18, 2021 14:46
@sampsyo
Copy link
Member

sampsyo commented Apr 18, 2021

Nice. This all looks good to go from here!

@jef jef merged commit e1a901d into master Apr 19, 2021
@jef jef deleted the chore/issue-template branch April 19, 2021 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants