Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for BillingPortal.Session #604

Merged
merged 1 commit into from
Jun 1, 2020
Merged

Add support for BillingPortal.Session #604

merged 1 commit into from
Jun 1, 2020

Conversation

moomerman
Copy link
Contributor

@coveralls
Copy link

coveralls commented May 21, 2020

Coverage Status

Coverage increased (+0.01%) to 89.623% when pulling b19846d on moomerman:feature/billing_portal into 0b941cd on code-corps:master.

@moomerman
Copy link
Contributor Author

Depends on #602 being merged to fix the tests that break because of the updated stripe mock required for this new endpoint.

@moomerman moomerman marked this pull request as ready for review May 21, 2020 17:34
@johannesE
Copy link

I am in need of this feature. Thanks for the PR @moomerman .

If someone could merge this and #602 and release a new version on hex, that would be awesome.

@moomerman
Copy link
Contributor Author

moomerman commented Jun 1, 2020

Since #602 was merged I've rebased and this is all good to go now 🚀

Copy link
Collaborator

@snewcomer snewcomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:yay

@snewcomer snewcomer merged commit 3b71b0a into beam-community:master Jun 1, 2020
@moomerman moomerman deleted the feature/billing_portal branch June 1, 2020 18:22
@lleger
Copy link

lleger commented Jun 25, 2020

@snewcomer Any chance we can get a new hex release with this PR?

@johannesE
Copy link

While I would also love a hex release, I am using the workaround in my mix.exs: {:stripity_stripe, git: "https://github.com/code-corps/stripity_stripe", ref: "60d69dde7dc17670a043e5199d159dd0ee403437"},
@lleger you probably knew that you could do that. But if not, then this might also help you.

@lleger
Copy link

lleger commented Jun 25, 2020

@johannesE Yep I'm doing the same in dev 😄 was hoping for a hex release before I ship to prod.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants