Update various stripe objects with missing fields, remove deprecated fields, and add support for some missing objects #602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The endpoint /issuing/card_details has been removed from the Stripe API. These details can be found at /issuing/cards/retrieve with the appropriate 'expand' parameters.
Since Issuing Disputes are no longer available in the Stripe API, remove the issuing disputes module and references to issuing disputes in issuing transaction.
|
^ Looks like Travis CI failed due to an older version of stripe-mock (0.70.0), tests pass locally if running a recent version (0.90.0), I'll add a commit to update. |
Add support for Price core resource
|
Is there anything I can do to help here? I am in need of this and #604 and don't want to create my own fork with these branches just so that you decide to merge them the day after. |
snewcomer
approved these changes
May 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did some work to cut down the number of warnings due to missing fields on structs when running
mix test, related to this issue: #517Some new fields required adding support for some smaller objects, namely
file_link,mandate,credit_note_line_item,customer_balance_transaction.Also added an explicit struct for
usage_record_summary, which is the object returned in the response forStripe.Subscriptions.UsageItem.list/3.The bulk of the changes are updates to existing stripe object structs to bring them back in line with the current API.
Finally, two objects were removed completely: Issuing Disputes, and Issuing Card Details, since they are no longer available in the API. (Let me know if these should be kept for legacy support).