Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 42 additions & 0 deletions .github/workflows/run-tox-tests.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,42 @@
name: run unit tests with tox
run-name: ${{ github.actor }} run unit tests with tox
on: [push]
jobs:
run-tox:
runs-on: ubuntu-latest
strategy:
fail-fast: false
matrix:
env:
- "3.10"
- "3.9"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have the results of these jobs running on GitHub?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

library:
- "Common"
- "Server"
- "LabController"
- "Client"
steps:
- uses: actions/checkout@v4
# Use uv instead of actions/setup-python and setuptools/etc
- name: Install the latest version of uv
uses: astral-sh/setup-uv@v6
with:
enable-cache: true
- name: Install Python
run: uv python install --python-preference only-managed ${{ matrix.env }}
- name: Install libkrb5-dev
run: sudo apt-get install -y libkrb5-dev
- name: Install tox
run: uv tool install --python-preference only-managed --python ${{ matrix.env }} tox --with ${{ matrix.library }}/ --with Common/
- name: Setup test suite
run: tox run -vv --notest --skip-missing-interpreters false -e ${{ matrix.env }}
env:
UV_PYTHON_PREFERENCE: "only-managed"

- name: Run test suite
run: tox run --skip-pkg-install -e ${{ matrix.env }}
env:
PYTEST_ADDOPTS: "-vv"
UV_PYTHON_PREFERENCE: "only-managed"
TOXLIB: ${{ matrix.library }}

13 changes: 13 additions & 0 deletions tox.ini

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make this run all the test suites (Server, LabController, etc).

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does, but the actions are not active in this branch somehow

Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
[testenv]
deps = nose
setuptools
six
lxml
gssapi
jinja2
werkzeug
gevent
daemon
SQLAlchemy

commands = nosetests -v -w . Common {env:TOXLIB}
Copy link

Copilot AI Jun 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The command line mixes a hard-coded 'Common' with a dynamic environment variable {env:TOXLIB}. Consider clarifying or consolidating the directories being tested to avoid potential duplication or ambiguity.

Suggested change
commands = nosetests -v -w . Common {env:TOXLIB}
commands = nosetests -v -w . {env:TOXLIB}/Common {env:TOXLIB}

Copilot uses AI. Check for mistakes.