Conversation
…ith will pull the libraries and its dependencies
There was a problem hiding this comment.
Can you make this run all the test suites (Server, LabController, etc).
There was a problem hiding this comment.
It does, but the actions are not active in this branch somehow
| matrix: | ||
| env: | ||
| - "3.10" | ||
| - "3.9" |
There was a problem hiding this comment.
Do you have the results of these jobs running on GitHub?
There was a problem hiding this comment.
There was a problem hiding this comment.
Pull Request Overview
This PR adds configuration to run unit tests using tox and uv via a GitHub Actions workflow. It aims to execute tests for Common, Server, Lab Controller, and Client across different Python versions.
- Adds a tox.ini file defining the test environment, dependencies, and nosetests command.
- Introduces a GitHub Actions workflow to install dependencies with uv and execute tox-based tests.
- Configures matrix builds to test multiple Python versions and libraries.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tox.ini | Defines the test environment, dependency list, and commands. |
| .github/workflows/run-tox-tests.yml | Sets up a GitHub Actions job to run tox tests using uv. |
Comments suppressed due to low confidence (1)
.github/workflows/run-tox-tests.yml:30
- Using both '--with ${{ matrix.library }}/' and '--with Common/' may lead to redundancy if matrix.library is set to 'Common'. Verify that this dual inclusion is intentional and clearly documented.
run: uv tool install --python-preference only-managed --python ${{ matrix.env }} tox --with ${{ matrix.library }}/ --with Common/
| daemon | ||
| SQLAlchemy | ||
|
|
||
| commands = nosetests -v -w . Common {env:TOXLIB} |
There was a problem hiding this comment.
The command line mixes a hard-coded 'Common' with a dynamic environment variable {env:TOXLIB}. Consider clarifying or consolidating the directories being tested to avoid potential duplication or ambiguity.
| commands = nosetests -v -w . Common {env:TOXLIB} | |
| commands = nosetests -v -w . {env:TOXLIB}/Common {env:TOXLIB} |
Run using uv and tox the existing unit tests for
Global
Common
Server
Lab Controller
Client
In a github actions workflow