Implement Plücker-Screw-Twist conversions #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Also fixes the Twist3.pitch() method.
VascoSch92
reviewed
Mar 3, 2024
| def ToPlucker(self): | ||
| if abs(self.theta) > 1e-4: | ||
| l = self.w / self.theta | ||
| return Plucker((self.v / self.theta) - self.pitch * l, l) |
There was a problem hiding this comment.
Suggested change
| return Plucker((self.v / self.theta) - self.pitch * l, l) | |
| return Plucker(self.v / self.theta - self.pitch * l, l) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an attempt to improve the issue reported in #61. While implementing these classes, I noticed that
Line3is a general abstraction that covers them all, therefore I didn't implement the additional validity check in theLine3constructor as I initially suggested. Although, the docs in there should be improved in the scope of this PR.An extensive study of the subject (based on the book of @petercorke) can be found in this Jupyter notebook. (The GIFs there are quite large to be rendered in an optimal way, I'll update the link once I move the post to a more convenient place)