Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manual update of yarn to update dependencies, remove FWI #2511

Merged
merged 6 commits into from
Jan 12, 2023

Conversation

conbrad
Copy link
Collaborator

@conbrad conbrad commented Jan 11, 2023

  • We have a lot of out of date dependencies, might as well get ahead of renovate bot
  • devexpress dependencies are removed
    • only used by FWI have a lot of complicated breaking changes and FWI is not supported (and I doubt used). We can resurrect it if it's requested but it's really holding us back maintenance-wise.
  • Adjusted some types coming from compile errors after updates
  • Mocks out ResizeObserver an internal dependency of openlayers maps, in a test, that jsdom doesn't have an implementation for: "ResizeObserver is not defined" error when running Jest ZeeCoder/use-resize-observer#40

Test Links:

Percentile Calculator
MoreCast
C-Haines
FireBat
FireBat bookmark
Auto Spatial Advisory (ASA)
HFI Calculator
FWI Calculator

@conbrad conbrad self-assigned this Jan 11, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Jan 11, 2023

Codecov Report

Merging #2511 (5299c68) into main (7fc68df) will increase coverage by 0.05%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##             main    #2511      +/-   ##
==========================================
+ Coverage   86.74%   86.79%   +0.05%     
==========================================
  Files         260      258       -2     
  Lines        8315     8303      -12     
  Branches      464      464              
==========================================
- Hits         7213     7207       -6     
+ Misses        993      987       -6     
  Partials      109      109              
Impacted Files Coverage Δ
web/src/app/Routes.tsx 66.66% <ø> (ø)
web/src/app/rootReducer.ts 100.00% <ø> (ø)
web/src/components/FilterColumnsModal.tsx 80.95% <ø> (ø)
web/src/components/WPSDatePicker.tsx 40.00% <0.00%> (-20.00%) ⬇️
web/src/utils/constants.ts 100.00% <ø> (ø)
...atures/hfiCalculator/components/DailyViewTable.tsx 81.81% <50.00%> (ø)
...tures/hfiCalculator/components/WeeklyViewTable.tsx 80.48% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@conbrad conbrad temporarily deployed to production January 12, 2023 16:55 Inactive
@conbrad conbrad merged commit da4c461 into main Jan 12, 2023
@conbrad conbrad deleted the task/remove-fwi-update-yarn branch January 12, 2023 18:28
vanislekahuna pushed a commit to vanislekahuna/wps that referenced this pull request Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants