Fixing code smells

bcgov · Jan 11, 2023 · 5299c68 · 5299c68
1 parent 2485e7f
commit 5299c68
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/web/src/features/hfiCalculator/components/DailyViewTable.tsx b/web/src/features/hfiCalculator/components/DailyViewTable.tsx
@@ -277,9 +277,9 @@ export const DailyViewTable = (props: Props): JSX.Element => {
                       />
                     </TableRow>
                     {sortBy(area.stations, station => station.order_of_appearance_in_planning_area_list).map(
-                      (station, idx) => {
+                      station => {
                         if (isUndefined(result)) {
-                          return <React.Fragment key={`daily-undefined-result${idx}`}></React.Fragment>
+                          return <React.Fragment key={`daily-undefined-result-${station.code}`}></React.Fragment>
                         }
                         const daily = getDailyForDay(station.code)
                         const selectedFuelType = getSelectedFuelType(
@@ -289,7 +289,7 @@ export const DailyViewTable = (props: Props): JSX.Element => {
                           props.fuelTypes
                         )
                         if (isUndefined(selectedFuelType)) {
-                          return <React.Fragment key={`daily-undefined-fuel-type-${idx}`}></React.Fragment>
+                          return <React.Fragment key={`daily-undefined-fuel-type-${station.code}`}></React.Fragment>
                         }
                         const grassCureError = !isValidGrassCure(daily, selectedFuelType)
                         const isRowSelected = !isUndefined(area) && stationCodeInSelected(area.id, station.code)

diff --git a/web/src/features/hfiCalculator/components/WeeklyViewTable.tsx b/web/src/features/hfiCalculator/components/WeeklyViewTable.tsx
@@ -187,7 +187,7 @@ export const WeeklyViewTable = (props: Props): JSX.Element => {
                         />
                       </TableRow>
                       {sortBy(area.stations, station => station.order_of_appearance_in_planning_area_list).map(
-                        (station, idx) => {
+                        station => {
                           const dailiesForStation = getDailiesByStationCode(result, station.code)
                           const isRowSelected = stationCodeInSelected(area.id, station.code)
                           const classNameForRow = !isRowSelected
@@ -201,7 +201,7 @@ export const WeeklyViewTable = (props: Props): JSX.Element => {
                             props.fuelTypes
                           )
                           if (isUndefined(selectedFuelType)) {
-                            return <React.Fragment key={`weekly-undefined-fuel-type-${idx}`}></React.Fragment>
+                            return <React.Fragment key={`weekly-undefined-fuel-type-${station.code}`}></React.Fragment>
                           }
                           return (
                             <TableRow className={classNameForRow} key={`station-${stationCode}`}>