Skip to content

Conversation

@DerekRoberts
Copy link
Member

@DerekRoberts DerekRoberts commented Jul 2, 2025


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

Copilot AI review requested due to automatic review settings July 2, 2025 18:56
@DerekRoberts DerekRoberts self-assigned this Jul 2, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds a default OpenShift server endpoint and updates the pr-close workflow steps to use this default when the oc_server secret isn’t provided.

  • Introduce DEFAULT_OC_SERVER as a workflow-level environment variable
  • Update each oc_server input to fall back to DEFAULT_OC_SERVER if the secret is unset
Comments suppressed due to low confidence (2)

.github/workflows/.pr-close.yml:126

  • [nitpick] The fallback expression for oc_server is duplicated across multiple steps. Consider defining a single workflow or job-level env var (e.g., OC_SERVER) that applies this fallback once and reuse it to reduce duplication and simplify future updates.
          oc_server: ${{ secrets.oc_server || env.DEFAULT_OC_SERVER }}

.github/workflows/.pr-close.yml:69

  • [nitpick] It could be helpful to add a brief comment above DEFAULT_OC_SERVER explaining its role and when it will be used as a fallback to improve clarity for future maintainers.
env:

@DerekRoberts DerekRoberts changed the title fix: oc_server default revisions fix: oc_server default revisions, improve workflow checks Jul 2, 2025
@DerekRoberts DerekRoberts changed the title fix: oc_server default revisions, improve workflow checks fix: oc_server default, improve workflow checks Jul 2, 2025
@DerekRoberts DerekRoberts moved this from New to Active in DevOps (NR) Jul 2, 2025
@DerekRoberts DerekRoberts merged commit a25c74e into main Jul 2, 2025
26 of 27 checks passed
@DerekRoberts DerekRoberts deleted the fix/prCloseSecrets branch July 2, 2025 19:21
@github-project-automation github-project-automation bot moved this from Active to Done in DevOps (NR) Jul 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants