fix: oc_server default, improve workflow checks (#174)

Author: DerekRoberts

.github/workflows/.pr-close.yml

@@ -66,6 +66,9 @@ on:
 
 permissions: {}
 
+env:
+  DEFAULT_OC_SERVER: https://api.silver.devops.gov.bc.ca:6443
+
 jobs:
   vars:
     if: inputs.packages != ''
@@ -120,7 +123,7 @@ jobs:
         with:
           oc_namespace: ${{ secrets.oc_namespace }}
           oc_token: ${{ secrets.oc_token }}
-          oc_server: ${{ secrets.oc_server }}
+          oc_server: ${{ secrets.oc_server || env.DEFAULT_OC_SERVER }}
           commands: |
             # Cleanup for Helm deployments
 
@@ -158,7 +161,7 @@ jobs:
         with:
           oc_namespace: ${{ secrets.oc_namespace }}
           oc_token: ${{ secrets.oc_token }}
-          oc_server: ${{ secrets.oc_server }}
+          oc_server: ${{ secrets.oc_server || env.DEFAULT_OC_SERVER }}
           commands: |
             # Cleanup for OpenShift template deployments, uses labels
 
@@ -171,7 +174,7 @@ jobs:
         with:
           oc_namespace: ${{ secrets.oc_namespace }}
           oc_token: ${{ secrets.oc_token }}
-          oc_server: ${{ secrets.oc_server }}
+          oc_server: ${{ secrets.oc_server || env.DEFAULT_OC_SERVER }}
           commands: |
             # Remove PVCs from OpenShift when PR closed
             echo "${{ inputs.remove_pvc }}" | while IFS= read -r pvc; do

.github/workflows/pr-close.yml

@@ -86,6 +86,18 @@ jobs:
       promote_tags: pr
       repository: bcgov/quickstart-openshift
 
+  cleanup:
+    name: Cleanup
+    needs: [deploys]
+    permissions:
+      packages: write
+    uses: ./.github/workflows/.pr-close.yml
+    secrets: inherit
+    with:
+      cleanup: helm
+      packages: backend frontend migrations
+      tag_promote: latest
+
   csr-generator: # testing, will be deleted
     name: Certificate Generation
     uses: ./.github/workflows/csr-generator.yml