Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE: Allow asserting on requests in tests #1069

Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open

FEATURE: Allow asserting on requests in tests #1069

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
27e3095
Allow asserting on the requests made
johngallagher Sep 12, 2024
3245079
Better name
johngallagher Sep 12, 2024
7f93ba1
Simpler
johngallagher Sep 12, 2024
a5ab52a
Use existing hash counter class
johngallagher Sep 12, 2024
88e9664
Add headers into the request
johngallagher Sep 12, 2024
b366874
Allow parsing JSON body
johngallagher Sep 12, 2024
fbf292f
Stop creating lots of new objects for garbage collection reasons
johngallagher Sep 12, 2024
c8815ee
Store a reference to existing keys
johngallagher Sep 12, 2024
fd04cbc
Reference existing objects in the hash
johngallagher Sep 13, 2024
6890a01
Deal with recycled objects
johngallagher Sep 14, 2024
2b8a895
Store the key not the hash
johngallagher Sep 14, 2024
3eaead4
Stop using named arguments because CI fails
johngallagher Sep 15, 2024
cb5c40c
Add helper and coverage
johngallagher Sep 15, 2024
577f64e
Merge branch 'master' into add-ability-to-assert-on-requests
johngallagher Sep 23, 2024
6705f53
fix: remove separate feature
johngallagher Sep 23, 2024
088aa26
fix: simplify
johngallagher Sep 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Better name
  • Loading branch information
@johngallagher
johngallagher committed Sep 12, 2024
commit 324507968c280348f4c42f819257f693818e3602
2 changes: 1 addition & 1 deletion spec/unit/request_registry_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@
end

describe "requests_made" do
it "should return an array of request signatures" do
it "returns the requests made" do
WebMock::RequestRegistry.instance.requested_signatures.put(WebMock::RequestSignature.new(:get, "www.example.com"))
WebMock::RequestRegistry.instance.requested_signatures.put(WebMock::RequestSignature.new(:put, "www.example.org"))
expect(WebMock::RequestRegistry.instance.requests_made.count).to eq(2)
Expand Down