Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE: Allow asserting on requests in tests #1069

Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Allow asserting on the requests made
  • Loading branch information
johngallagher committed Sep 12, 2024
commit 27e3095204f6ae08aacdd6f8f78dca6d00c73ca4
24 changes: 24 additions & 0 deletions lib/webmock/request_registry.rb
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,19 @@ class RequestRegistry

attr_accessor :requested_signatures

class Request
attr_accessor :method, :uri

def self.from_webmock_request_signature(request_signature)
new(method: request_signature.method, uri: request_signature.uri)
end

def initialize(method:, uri:)
@method = method
@uri = uri
end
end

def initialize
reset!
end
Expand All @@ -21,6 +34,17 @@ def times_executed(request_pattern)
end.inject(0) { |sum, (_, times_executed)| sum + times_executed }
end

def requests_made
to_a
end

def to_a
requested_signatures.
hash.
flat_map { |request_signature, number_of_requests| [request_signature] * number_of_requests }.
map { |request_signature| Request.from_webmock_request_signature(request_signature) }
end

def to_s
if requested_signatures.hash.empty?
"No requests were made."
Expand Down
11 changes: 11 additions & 0 deletions spec/unit/request_registry_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -92,4 +92,15 @@
end
end

describe "requests_made" do
it "should return an array of request signatures" do
WebMock::RequestRegistry.instance.requested_signatures.put(WebMock::RequestSignature.new(:get, "www.example.com"))
WebMock::RequestRegistry.instance.requested_signatures.put(WebMock::RequestSignature.new(:put, "www.example.org"))
expect(WebMock::RequestRegistry.instance.requests_made.count).to eq(2)
expect(WebMock::RequestRegistry.instance.requests_made[0].method).to eq(:get)
expect(WebMock::RequestRegistry.instance.requests_made[0].uri).to eq(Addressable::URI.parse("http://www.example.com/"))
expect(WebMock::RequestRegistry.instance.requests_made[1].method).to eq(:put)
expect(WebMock::RequestRegistry.instance.requests_made[1].uri).to eq(Addressable::URI.parse("http://www.example.org/"))
end
end
end