Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flow property updates ADR and specification extensions #91

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

philipnbbc
Copy link
Contributor

Details

This PR came about because an question was raised about whether the Flow source_id can be updated. The proposal is to allow it to be updated to fix incorrect values for example. This may be restricted by systems that sit in front of TAMS API that check permissions for example.

This PR offers some changes wrt updating Flow properties but proposes no change at this stage. Requirements may arise in future that changes this.

This PR adds endpoints for bit rate (see also #86) and flow collection properties. This is to make it consistent with other properties that are likely to be updated.

Pivotal Story (if relevant)

Story URL: https://www.pivotaltracker.com/story/show/188210268

Related PRs

Where appropriate. Indicate order to be merged.

Submitter PR Checks

(tick as appropriate)

  • PR completes task/fixes bug
  • API version has been incremented if necessary
  • ADR status has been updated, and ADR implementation has been recorded
  • Documentation updated (README, etc.)
  • PR added to Pivotal story (if relevant)
  • Follow-up stories added to git push --set-upstream origin philipn-flow-property-updatesPivotal

Reviewer PR Checks

(tick as appropriate)

  • PR completes task/fixes bug
  • Design makes sense, and fits with our current code base
  • Code is easy to follow
  • PR size is sensible
  • Commit history is sensible and tidy

Info on PRs

The checks above are guidelines. They don't all have to be ticked, but they should all have been considered.

@philipnbbc philipnbbc requested a review from a team as a code owner November 13, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant