Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adr: add flow bit rate property definitions ADR #86

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

philipnbbc
Copy link
Contributor

Details

This PR adds draft ADR for discussion. It documents possible Flow bit rate property definitions and additional related properties.

Pivotal Story (if relevant)

Story URL: https://www.pivotaltracker.com/story/show/188127666

Related PRs

Where appropriate. Indicate order to be merged.

Submitter PR Checks

(tick as appropriate)

  • PR completes task/fixes bug
  • API version has been incremented if necessary
  • ADR status has been updated, and ADR implementation has been recorded
  • Documentation updated (README, etc.)
  • PR added to Pivotal story (if relevant)
  • Follow-up stories added to Pivotal

Reviewer PR Checks

(tick as appropriate)

  • PR completes task/fixes bug
  • Design makes sense, and fits with our current code base
  • Code is easy to follow
  • PR size is sensible
  • Commit history is sensible and tidy

Info on PRs

The checks above are guidelines. They don't all have to be ticked, but they should all have been considered.

@philipnbbc philipnbbc requested a review from a team as a code owner August 28, 2024 14:35
This change follows a discussion which decided that segment duration should
be added and a maximum 1.5 variance assumed.

It was decided that the maximum segment duration was not required.

The need to have segment size and maximum segment size requires further input.
@philipnbbc philipnbbc force-pushed the philipn-bit-rate-properties branch 2 times, most recently from 25b9710 to e417d03 Compare November 11, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant