-
Notifications
You must be signed in to change notification settings - Fork 3
CGPROD-3888 Add Voice Over to Gel Buttons #537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sophia4422
wants to merge
19
commits into
master
Choose a base branch
from
CGPROD-3888-gel-voice
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
3090efe
made sound happen on hover
sophia4422 c0c48ec
changed sound to 'play'
sophia4422 0791fc1
pause button hover sound
sophia4422 adcc3b0
home sounds: exit, how to play, settings
sophia4422 1db6d90
narrative screen sounds: continue and skip
sophia4422 eb63f2e
character sounds for home pause next -not back
sophia4422 553a03b
pointerover test.. needs checking
sophia4422 a6d9da4
more hover sound tests
sophia4422 dd07670
trying to reformat
sophia4422 205b4d8
comment
sophia4422 659890c
uncomment
sophia4422 9abd428
convert indent to spaces
sophia4422 a67e9a3
spacing
sophia4422 3531125
spacing
sophia4422 044fcf0
spacing
sophia4422 f4ce36e
Merge branch 'master' into CGPROD-3888-gel-voice
sophia4422 c62bac1
Remove most sounds except home screen
alex-s2 4518fae
fix json
alex-s2 4e9f3b4
Merge branch 'master' into CGPROD-3888-gel-voice
alex-s2 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not 100% sure as on mobile but has your editor reformatted all the existing config? The diff might be a lot smaller if it wasn't.