CGPROD-3888 Add Voice Over to Gel Buttons#537
Open
sophia4422 wants to merge 19 commits intomasterfrom
Open
Conversation
Contributor
There was a problem hiding this comment.
I'm not 100% sure as on mobile but has your editor reformatted all the existing config? The diff might be a lot smaller if it wasn't.
Contributor
|
Looks good, it would be nice to see if you could sort the diff out though on all the config changes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For spike ticket: CGPROD-3888
I have added temporary mp4s for now which make a sound when you hover over the button.
(Not all of the buttons have sounds, as waiting on proper audio - sound has been taken from another game)