Fix Java coverage support on Windows by adding coverage_main_class to launch_info #311
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmeum
approved these changes
Aug 6, 2025
hvadehra
reviewed
Aug 7, 2025
hvadehra
approved these changes
Aug 7, 2025
Contributor
Author
|
Hi! I’d like to kindly request a new release of |
copybara-service bot
pushed a commit
that referenced
this pull request
Aug 7, 2025
Context: #311 (comment) (ignore-relnotes) PiperOrigin-RevId: 792147204 Change-Id: Ic881922527848bf51e785cf6d275eebcbe55ab7f
Contributor
Author
Thank you! Appreciate the quick release 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR enables Java code coverage to work properly on Windows by adding the
coverage_main_classto thelaunch_infometadata inbazel_java_binary.bzl. Without this addition, Bazel fails to properly instrument and run Java binaries with coverage enabled on Windows platforms.Changes
coverage_main_classtolaunch_infoinbazel_java_binary.bzlto explicitly define the main class used during coverage runs.Motivation