Fix Java code coverage on Windows #26710
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KrishnaM256
force-pushed
the
fix-java-coverage
branch
from
241f6f4 to
2f8de99
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes bazel#18839 by enabling Java code coverage to work correctly on Windows.
To fix this issue, the
coverage_main_classfield is now included in thelaunch_info. This ensures that theJACOCO_MAIN_CLASSenvironment variable is correctly set during execution. Without it, the coverage tool is unable to identify the correct entry point on Windows.A related change is submitted in rules_java#311, which depends on this update. With both changes applied, Java code coverage is successfully collected on Windows using JaCoCo.