[8.6.0] Don't repeatedly request QueryWriteStatus if the server doesn't support it (https://github.com/bazelbuild/bazel/pull/28235) #28474
+9
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rt it (bazelbuild#28235) After the first time a `QueryWriteStatus` call fails with `UNIMPLEMENTED`, stop calling the method to avoid an additional roundtrip on every retry. Closes bazelbuild#28235. PiperOrigin-RevId: 861621112 Change-Id: Iedf106f771fe3105c4c9e8e7b44d14907bd4e835
bazel-io
added
team-Remote-Exec
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
The changes effectively address the issue of repeatedly calling QueryWriteStatus when the server does not support it. The introduction of an AtomicBoolean flag and the necessary refactoring of AsyncUpload to a non-static inner class are appropriate and correctly implemented. The logic ensures that once an UNIMPLEMENTED status is received, subsequent calls to query() will bypass the QueryWriteStatus request, optimizing network roundtrips. This is a solid improvement to the ByteStreamUploader.
Member
|
@coeuvre Could you please take a look at the test error? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the first time a
QueryWriteStatuscall fails withUNIMPLEMENTED, stop calling the method to avoid an additional roundtrip on every retry.Closes #28235.
PiperOrigin-RevId: 861621112
Change-Id: Iedf106f771fe3105c4c9e8e7b44d14907bd4e835
Commit fb62559