Don't repeatedly request QueryWriteStatus if the server doesn't support it #28235
+9
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmeum
changed the title
github-actions
bot
added
team-Remote-Exec
After the first time a `QueryWriteStatus` call fails with `UNIMPLEMENTED`, stop calling the method to avoid an additional roundtrip on every retry.
fmeum
force-pushed
the
persistent-query-write-status
branch
from
93763db to
96dfeda
Compare
Collaborator
Author
|
@bazel-io fork 8.6.0 |
Collaborator
Author
|
@bazel-io fork 9.0.0 |
fmeum
added
the
soft-release-blocker
Wyverald
removed
the
soft-release-blocker
Member
|
@fmeum For future reference, the |
coeuvre
approved these changes
Jan 26, 2026
coeuvre
added
awaiting-PR-merge
github-actions
bot
removed
the
awaiting-PR-merge
bazel-io
pushed a commit
to bazel-io/bazel
that referenced
this pull request
Jan 28, 2026
…rt it (bazelbuild#28235) After the first time a `QueryWriteStatus` call fails with `UNIMPLEMENTED`, stop calling the method to avoid an additional roundtrip on every retry. Closes bazelbuild#28235. PiperOrigin-RevId: 861621112 Change-Id: Iedf106f771fe3105c4c9e8e7b44d14907bd4e835
fmeum
added a commit
to buildbuddy-io/buildbuddy
that referenced
this pull request
Jan 28, 2026
Since we don't support retrying uploads from a non-zero offset, inform the client about this in a way that let's it avoid future (unnecessary) calls. This will have the desired effect as of Bazel 8.6.0 and 9.1.0 while resulting in no change in behavior for earlier versions (bazelbuild/bazel#28235)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the first time a
QueryWriteStatuscall fails withUNIMPLEMENTED, stop calling the method to avoid an additional roundtrip on every retry.