-
Notifications
You must be signed in to change notification settings - Fork 4.4k
Inject package_metadata into module repos #27829
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
0abce9f to
4ad0d6f
Compare
|
FYI @mzeren-vmw @Yannic |
|
Does the PURL fragment already provide license info? FYI @kotlaja this might be useful for the GDC Bzlmod migration. |
It doesn't, but it uniquely identifies the source for that info. My personal opinion is that "Bazel module <-> Bazel PURL" is a trivial one-to-one mapping and "Bazel module -> license" is a function that can only be evaluated by a lawyer, so it makes sense to automate the "Bazel module -> PURL" part and let users figure out the "PURL -> license" part, perhaps even out of band. |
Well.. not really. Because with module overrides, you can get local patches which make my code labeled as purl=x different from your code labeled as purl=X. PURL's are like any other URL, they are sort of a hint more than anything precise. |
|
@fweikert Please also take a look |
|
I can send a followup pr to address @aiuto's concern: In the case of a |
Allows targets to be tagged as manual. This is relevant for bazelbuild/bazel#27829: if we inject targets, we don't want folks to be confused by them showing up in their bazel build @rrepo//....
|
@bazel-io fork 9.0.0 |
|
@fmeum We have some test failures on RBE during import: https://buildkite.com/bazel/google-bazel-presubmit/builds/98041 Maybe try to rebase to HEAD and see if it reproduce on the PR? |
|
I will take a look and address @aiuto's comment along the way. |
|
Oh, postsubmit is red since https://buildkite.com/bazel/bazel-bazel/builds/34042 |
|
postsubmit is due to some RBE infra change, we are fixing it. |
eaa95a2 to
66af745
Compare
66af745 to
6bf21d1
Compare
|
@aiuto Could you take another look? I hope I addressed your concern. |
RELNOTES: Bazel modules from a registry that don't include a REPO.bazel file now automatically have a
package_metadatatarget with their PURL injected and registered as the default for all targets in the module repo. Any module that is patched locally via asingle_version_overridewill receive a deterministic version modifier that is unique on best-effort basis.